]> git.ipfire.org Git - thirdparty/asterisk.git/commit
chan_sip.c: Fix reinviteid deadlock potential. 98/2398/3
authorRichard Mudgett <rmudgett@digium.com>
Wed, 9 Mar 2016 22:34:53 +0000 (16:34 -0600)
committerRichard Mudgett <rmudgett@digium.com>
Wed, 16 Mar 2016 19:53:00 +0000 (14:53 -0500)
commit43556b800b7838fc989f243a2974d33a8f8a12ce
tree07f7905e9c1e2b3a6222a06e6c61e242584cfa7f
parent38c1cdab2ce3f5f00cd5a6a0f561910d9265bea7
chan_sip.c: Fix reinviteid deadlock potential.

This patch is part of a series to resolve deadlocks in chan_sip.c.

Stopping a scheduled event can result in a deadlock if the scheduled event
is running when you try to stop the event.  If you hold a lock needed by
the scheduled event while trying to stop the scheduled event then a
deadlock can happen.  The general strategy for resolving the deadlock
potential is to push the actual starting and stopping of the scheduled
events off onto the scheduler/do_monitor() thread by scheduling an
immediate one shot scheduled event.  Some restructuring may be needed
because the code may assume that the start/stop of the scheduled events is
immediate.

ASTERISK-25023

Change-Id: I9c11b9d597468f63916c99e1dabff9f4a46f84c1
channels/chan_sip.c