]> git.ipfire.org Git - thirdparty/krb5.git/commit
Fix PKINIT memory leaks 1169/head
authorGreg Hudson <ghudson@mit.edu>
Thu, 11 Mar 2021 02:53:33 +0000 (21:53 -0500)
committerGreg Hudson <ghudson@mit.edu>
Tue, 23 Mar 2021 00:02:44 +0000 (20:02 -0400)
commitaee8a823db095eda5842420e917fe7a664a0e7af
tree056ccd8253cb1914c31f0d159060d613d4e8b29b
parent81bdb47d8ded390263d8ee48f71d5c312b4f1736
Fix PKINIT memory leaks

pkinit_client_process() calls pkinit_client_profile() a second time,
leaking the values obtained the first time.  Remove the call.

Commit 13ae08e70a05768d4f65978ce1a8d4e16fec0d35 introduced more
possibilities for process_option_identity() to return failure after it
filled in some fields.  PKCS11 option parsing already prevents leaks
by freeing old values before setting new ones; do so in the other
option-parsing functions as well.

ticket: 8991 (new)
src/plugins/preauth/pkinit/pkinit_clnt.c
src/plugins/preauth/pkinit/pkinit_identity.c