]> git.ipfire.org Git - thirdparty/suricata.git/commit
app-layer: remove ALPROTO_TEST and tests 12051/head
authorPhilippe Antoine <pantoine@oisf.net>
Tue, 29 Oct 2024 10:00:15 +0000 (11:00 +0100)
committerPhilippe Antoine <pantoine@oisf.net>
Tue, 29 Oct 2024 10:00:15 +0000 (11:00 +0100)
commit292c218a48a7e8eb57499f0f74f683ea4d111c4e
treecfe67dbde75e1e82e97b942f65bd08d14659d5eb
parent3a7eef812198118fa0b96059e70074bec5a8cdbe
app-layer: remove ALPROTO_TEST and tests

These tests purpose seems to have been lost.
Registering a alproto with a parser function that always fails,
and just testing that AppLayerParserParse returned -1...
We would get the same result  without registering a parser function,
or using ALPROTO_FAILED as argument to AppLayerParserParse

The comment says "Test the deallocation of app layer parser memory
on occurrence of error in the parsing process."
but I do not see how this is tested.
src/app-layer-parser.c
src/app-layer-parser.h
src/app-layer-protos.c
src/app-layer-protos.h