]> git.ipfire.org Git - thirdparty/krb5.git/commit
Eliminate old-style function declarations 1304/head
authorKen Hornstein <kenh@cmf.nrl.navy.mil>
Sat, 10 Jun 2023 03:53:53 +0000 (23:53 -0400)
committerGreg Hudson <ghudson@mit.edu>
Mon, 24 Jul 2023 14:40:33 +0000 (10:40 -0400)
commit4b9d7f7c107f01a61600fddcd8cde3812d0366a2
treebdf5218ee1040afa422c48b1d0030a82a7278280
parent0f870b1bcad960fd5319a3f97aafd7f4a289e2fb
Eliminate old-style function declarations

The C2x standard removes support for non-prototype function
declarations, and clang 15 issues warnings for them
(https://reviews.llvm.org/D122895).  Add -Werror=strict-prototypes to
the build and fix all of the non-prototype declarations and
definitions.

For RPC code, try to be consistent with libtirpc and recent *BSD
versions of rpcgen.  This includes casting each time a concrete
function is used as an xdrproc_t value, since each XDR per-type
function accepts a different object pointer type.  A few invocations
of xdrproc_t values pass a third argument with value LASTUNSIGNED,
even though XDR per-type functions accept only two parameters.
libtirpc has removed these third arguments; do so here as well.

[ghudson@mit.edu: added -Werror=strict-prototypes and fixed
declarations it breaks under gcc and clang; added xdrproc_t changes;
rewrote commit message; style changes]
256 files changed:
src/aclocal.m4
src/appl/gss-sample/gss-client.c
src/appl/gss-sample/gss-misc.c
src/appl/gss-sample/gss-server.c
src/appl/user_user/server.c
src/clients/kdestroy/kdestroy.c
src/clients/kinit/kinit.c
src/clients/klist/klist.c
src/clients/ksu/authorization.c
src/clients/ksu/ccache.c
src/clients/ksu/heuristic.c
src/clients/ksu/krb_auth_su.c
src/clients/ksu/main.c
src/clients/kvno/kvno.c
src/include/gssrpc/auth_gssapi.h
src/include/gssrpc/xdr.h
src/include/k5-int.h
src/include/k5-plugin.h
src/include/net-server.h
src/kadmin/cli/getdate.y
src/kadmin/cli/kadmin.c
src/kadmin/cli/keytab.c
src/kadmin/dbutil/kdb5_create.c
src/kadmin/dbutil/kdb5_destroy.c
src/kadmin/dbutil/kdb5_stash.c
src/kadmin/dbutil/kdb5_util.c
src/kadmin/dbutil/ovload.c
src/kadmin/dbutil/strtok.c
src/kadmin/ktutil/ktutil.c
src/kadmin/ktutil/ktutil_funcs.c
src/kadmin/server/ipropd_svc.c
src/kadmin/server/kadm_rpc_svc.c
src/kadmin/server/ovsec_kadmd.c
src/kdc/t_ndr.c
src/kdc/t_replay.c
src/kprop/kpropd.c
src/kprop/kproplog.c
src/lib/apputils/net-server.c
src/lib/crypto/builtin/aes/aes-gen.c
src/lib/crypto/builtin/camellia/camellia-gen.c
src/lib/crypto/builtin/des/des_int.h
src/lib/crypto/builtin/des/destest.c
src/lib/crypto/builtin/des/t_verify.c
src/lib/crypto/builtin/sha1/t_shs.c
src/lib/crypto/builtin/sha1/t_shs3.c
src/lib/crypto/crypto_tests/aes-test.c
src/lib/crypto/crypto_tests/camellia-test.c
src/lib/crypto/crypto_tests/t_cf2.c
src/lib/crypto/crypto_tests/t_cts.c
src/lib/crypto/crypto_tests/t_encrypt.c
src/lib/crypto/crypto_tests/t_fork.c
src/lib/crypto/crypto_tests/t_hmac.c
src/lib/crypto/crypto_tests/t_mddriver.c
src/lib/crypto/crypto_tests/t_nfold.c
src/lib/crypto/crypto_tests/t_prf.c
src/lib/crypto/crypto_tests/t_sha2.c
src/lib/gssapi/generic/t_seqstate.c
src/lib/gssapi/krb5/accept_sec_context.c
src/lib/gssapi/krb5/compare_name.c
src/lib/gssapi/krb5/context_time.c
src/lib/gssapi/krb5/delete_sec_context.c
src/lib/gssapi/krb5/disp_name.c
src/lib/gssapi/krb5/disp_status.c
src/lib/gssapi/krb5/export_sec_context.c
src/lib/gssapi/krb5/gssapi_krb5.c
src/lib/gssapi/krb5/import_name.c
src/lib/gssapi/krb5/import_sec_context.c
src/lib/gssapi/krb5/indicate_mechs.c
src/lib/gssapi/krb5/init_sec_context.c
src/lib/gssapi/krb5/inq_context.c
src/lib/gssapi/krb5/inq_cred.c
src/lib/gssapi/krb5/inq_names.c
src/lib/gssapi/krb5/k5seal.c
src/lib/gssapi/krb5/k5unseal.c
src/lib/gssapi/krb5/process_context_token.c
src/lib/gssapi/krb5/rel_cred.c
src/lib/gssapi/krb5/rel_name.c
src/lib/gssapi/krb5/rel_oid.c
src/lib/gssapi/krb5/ser_sctx.c
src/lib/gssapi/krb5/util_cksum.c
src/lib/gssapi/krb5/util_seed.c
src/lib/gssapi/krb5/util_seqnum.c
src/lib/gssapi/krb5/val_cred.c
src/lib/gssapi/krb5/wrap_size_limit.c
src/lib/gssapi/mechglue/g_accept_sec_context.c
src/lib/gssapi/mechglue/g_acquire_cred.c
src/lib/gssapi/mechglue/g_acquire_cred_with_pw.c
src/lib/gssapi/mechglue/g_canon_name.c
src/lib/gssapi/mechglue/g_compare_name.c
src/lib/gssapi/mechglue/g_context_time.c
src/lib/gssapi/mechglue/g_delete_sec_context.c
src/lib/gssapi/mechglue/g_dsp_name.c
src/lib/gssapi/mechglue/g_dsp_status.c
src/lib/gssapi/mechglue/g_dup_name.c
src/lib/gssapi/mechglue/g_exp_sec_context.c
src/lib/gssapi/mechglue/g_export_name.c
src/lib/gssapi/mechglue/g_glue.c
src/lib/gssapi/mechglue/g_imp_name.c
src/lib/gssapi/mechglue/g_imp_sec_context.c
src/lib/gssapi/mechglue/g_init_sec_context.c
src/lib/gssapi/mechglue/g_initialize.c
src/lib/gssapi/mechglue/g_inq_cred.c
src/lib/gssapi/mechglue/g_inq_names.c
src/lib/gssapi/mechglue/g_mechname.c
src/lib/gssapi/mechglue/g_oid_ops.c
src/lib/gssapi/mechglue/g_process_context.c
src/lib/gssapi/mechglue/g_rel_buffer.c
src/lib/gssapi/mechglue/g_rel_cred.c
src/lib/gssapi/mechglue/g_rel_name.c
src/lib/gssapi/mechglue/g_rel_oid_set.c
src/lib/gssapi/mechglue/g_sign.c
src/lib/gssapi/mechglue/g_store_cred.c
src/lib/gssapi/mechglue/g_unseal.c
src/lib/gssapi/mechglue/g_unwrap_aead.c
src/lib/gssapi/mechglue/g_unwrap_iov.c
src/lib/gssapi/mechglue/g_verify.c
src/lib/gssapi/mechglue/g_wrap_aead.c
src/lib/gssapi/mechglue/g_wrap_iov.c
src/lib/kadm5/clnt/client_rpc.c
src/lib/kadm5/kadm_rpc.h
src/lib/kadm5/kadm_rpc_xdr.c
src/lib/kadm5/misc_free.c
src/lib/kadm5/srv/adb_xdr.c
src/lib/kadm5/srv/svr_principal.c
src/lib/kadm5/str_conv.c
src/lib/kadm5/t_kadm5.c
src/lib/kdb/kdb5.c
src/lib/kdb/kdb_cpw.c
src/lib/kdb/keytab.c
src/lib/kdb/t_stringattr.c
src/lib/krad/packet.c
src/lib/krad/t_attr.c
src/lib/krad/t_attrset.c
src/lib/krad/t_code.c
src/lib/krb5/ccache/cc_keyring.c
src/lib/krb5/krb/plugin.c
src/lib/krb5/krb/t_authdata.c
src/lib/krb5/krb/t_response_items.c
src/lib/krb5/krb/t_ser.c
src/lib/krb5/krb/t_sname_match.c
src/lib/krb5/krb/t_valid_times.c
src/lib/krb5/rcache/t_memrcache.c
src/lib/rpc/auth_gss.c
src/lib/rpc/auth_gssapi.c
src/lib/rpc/auth_gssapi_misc.c
src/lib/rpc/authunix_prot.c
src/lib/rpc/clnt_perror.c
src/lib/rpc/clnt_raw.c
src/lib/rpc/dyn.c
src/lib/rpc/pmap_clnt.c
src/lib/rpc/pmap_getmaps.c
src/lib/rpc/pmap_getport.c
src/lib/rpc/pmap_prot2.c
src/lib/rpc/pmap_rmt.c
src/lib/rpc/rpc_prot.c
src/lib/rpc/svc.c
src/lib/rpc/svc_auth_gss.c
src/lib/rpc/svc_auth_gssapi.c
src/lib/rpc/svc_simple.c
src/lib/rpc/unit-test/client.c
src/lib/rpc/unit-test/rpc_test_clnt.c
src/lib/rpc/unit-test/rpc_test_svc.c
src/lib/rpc/unit-test/server.c
src/lib/rpc/xdr.c
src/lib/rpc/xdr_array.c
src/lib/rpc/xdr_rec.c
src/lib/rpc/xdr_reference.c
src/lib/rpc/xdr_sizeof.c
src/plugins/kdb/db2/db2_exp.c
src/plugins/kdb/db2/libdb2/btree/bt_close.c
src/plugins/kdb/db2/libdb2/btree/bt_conv.c
src/plugins/kdb/db2/libdb2/btree/bt_delete.c
src/plugins/kdb/db2/libdb2/btree/bt_get.c
src/plugins/kdb/db2/libdb2/btree/bt_open.c
src/plugins/kdb/db2/libdb2/btree/bt_overflow.c
src/plugins/kdb/db2/libdb2/btree/bt_page.c
src/plugins/kdb/db2/libdb2/btree/bt_put.c
src/plugins/kdb/db2/libdb2/btree/bt_search.c
src/plugins/kdb/db2/libdb2/btree/bt_seq.c
src/plugins/kdb/db2/libdb2/btree/bt_split.c
src/plugins/kdb/db2/libdb2/btree/bt_utils.c
src/plugins/kdb/db2/libdb2/db/db.c
src/plugins/kdb/db2/libdb2/hash/dbm.c
src/plugins/kdb/db2/libdb2/hash/hash.c
src/plugins/kdb/db2/libdb2/hash/hash_bigkey.c
src/plugins/kdb/db2/libdb2/hash/hash_func.c
src/plugins/kdb/db2/libdb2/hash/hash_log2.c
src/plugins/kdb/db2/libdb2/hash/hash_page.c
src/plugins/kdb/db2/libdb2/hash/hsearch.c
src/plugins/kdb/db2/libdb2/mpool/mpool.c
src/plugins/kdb/db2/libdb2/recno/rec_close.c
src/plugins/kdb/db2/libdb2/recno/rec_delete.c
src/plugins/kdb/db2/libdb2/recno/rec_get.c
src/plugins/kdb/db2/libdb2/recno/rec_open.c
src/plugins/kdb/db2/libdb2/recno/rec_put.c
src/plugins/kdb/db2/libdb2/recno/rec_search.c
src/plugins/kdb/db2/libdb2/recno/rec_seq.c
src/plugins/kdb/db2/libdb2/recno/rec_utils.c
src/plugins/kdb/db2/libdb2/test/dbtest.c
src/plugins/kdb/db2/pol_xdr.c
src/plugins/kdb/ldap/ldap_util/kdb5_ldap_util.c
src/plugins/kdb/lmdb/kdb_lmdb.c
src/plugins/kdb/test/kdb_test.c
src/plugins/preauth/pkinit/pkinit_crypto_openssl.c
src/plugins/preauth/spake/t_vectors.c
src/tests/asn.1/krb5_decode_test.c
src/tests/asn.1/krb5_encode_test.c
src/tests/asn.1/t_trval.c
src/tests/asn.1/trval.c
src/tests/conccache.c
src/tests/create/kdb5_mkdums.c
src/tests/forward.c
src/tests/gss-threads/gss-client.c
src/tests/gss-threads/gss-server.c
src/tests/gssapi/reload.c
src/tests/gssapi/t_add_cred.c
src/tests/gssapi/t_enctypes.c
src/tests/gssapi/t_invalid.c
src/tests/gssapi/t_oid.c
src/tests/gssapi/t_spnego.c
src/tests/hammer/kdc5_hammer.c
src/tests/kdbtest.c
src/tests/misc/test_getpw.c
src/tests/plugorder.c
src/tests/shlib/t_loader.c
src/tests/softpkcs11/main.c
src/tests/t_inetd.c
src/tests/test1.c
src/tests/verify/kdb5_verify.c
src/util/et/error_message.c
src/util/et/test_et.c
src/util/profile/prof_init.c
src/util/profile/t_profile.c
src/util/profile/test_load.c
src/util/profile/test_parse.c
src/util/profile/test_profile.c
src/util/profile/test_vtable.c
src/util/ss/error.c
src/util/ss/execute_cmd.c
src/util/ss/help.c
src/util/ss/invocation.c
src/util/ss/list_rqs.c
src/util/ss/listen.c
src/util/ss/pager.c
src/util/ss/parse.c
src/util/ss/prompt.c
src/util/ss/request_tbl.c
src/util/ss/requests.c
src/util/ss/ss.h
src/util/ss/ss_internal.h
src/util/support/plugins.c
src/util/support/t_hashtab.c
src/util/support/t_hex.c
src/util/support/t_json.c
src/util/support/t_k5buf.c
src/util/support/t_unal.c