]> git.ipfire.org Git - thirdparty/rrdtool-1.x.git/commitdiff
src/rrd_modify.c: fix Coverity CID#32406 Logically dead code
authorMarek Schimara <Marek.Schimara@bull.net>
Wed, 15 Jun 2016 13:48:34 +0000 (15:48 +0200)
committerMarek Schimara <Marek.Schimara@bull.net>
Thu, 23 Jun 2016 14:32:33 +0000 (16:32 +0200)
        CWE-561 / https://cwe.mitre.org/data/definitions/561.html

        Either
                finalout = rrd_modify_structure == NULL => goto done;
        or
                finalout = rrd_modify_structure != NULL => rc = 0;

src/rrd_modify.c

index 86fc47b9a59067cd929f7bad31409844dd2460b0..a6a5033fce274d8c5fc9c0450114b27b89741077 100644 (file)
@@ -997,10 +997,6 @@ done:
     }
     if (rc != 0) {
        out = NULL;
-       if (finalout) {
-           rrd_memory_free(finalout);
-           free(finalout);
-       }
        finalout = NULL;
     }