]> git.ipfire.org Git - thirdparty/openssl.git/commitdiff
Fix state handling of keccak_final for s390x.
authorHolger Dengler <dengler@linux.ibm.com>
Wed, 27 Sep 2023 13:43:18 +0000 (15:43 +0200)
committerHolger Dengler <dengler@linux.ibm.com>
Fri, 10 Nov 2023 13:26:27 +0000 (14:26 +0100)
The digest life-cycle state diagram has been updated for XOF. Fix the
state handling in s390x_keccac_final() according to the updated state
diagram.

Signed-off-by: Holger Dengler <dengler@linux.ibm.com>
Reviewed-by: Shane Lontis <shane.lontis@oracle.com>
Reviewed-by: Todd Short <todd.short@me.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/22221)

providers/implementations/digests/sha3_prov.c

index 34620cf95a643571972bc02a6f2ae4bf4d993bf8..f691273bafdbe64645cb92096a344a27881976b8 100644 (file)
@@ -235,6 +235,10 @@ static int s390x_keccakc_final(void *vctx, unsigned char *out, size_t outlen,
 
     if (!ossl_prov_is_running())
         return 0;
+    if (!(ctx->xof_state == XOF_STATE_INIT ||
+          ctx->xof_state == XOF_STATE_ABSORB))
+        return 0;
+    ctx->xof_state = XOF_STATE_FINAL;
     if (outlen == 0)
         return 1;
     memset(ctx->buf + num, 0, bsz - num);