fixup: Do not rely on dieOnConnectionFailure() to throw (so much)

That method should probably be rewritten to avoid excessive throwing in
favor of mustStop() or a similar call, but that polishing is outside
this branch scope. Let's just attempt to minimize future code changes
by not relying on dieOnConnectionFailure() unwinding the stack.

diff --git a/src/adaptation/icap/Xaction.cc b/src/adaptation/icap/Xaction.cc
index 4ae30fc599f6fae5cf28131efb6fdf13ac85be08..3e3de02188467e51e104702c85e5c6cc7b65d2ca 100644 (file)
--- a/src/adaptation/icap/Xaction.cc
+++ b/src/adaptation/icap/Xaction.cc
@@ -269,8 +269,8 @@ void Adaptation::Icap::Xaction::noteCommConnected(const CommConnectCbParams &io)
 
     if (io.flag != Comm::OK)
         dieOnConnectionFailure(); // throws
-
-    successfullyConnected();
+    else
+        successfullyConnected();
 }
 
 /// called when successfully connected to an ICAP service