]> git.ipfire.org Git - thirdparty/haproxy.git/commitdiff
BUG/MINOR: quic: Missing call to task_queue() in qc_idle_timer_do_rearm()
authorFrédéric Lécaille <flecaille@haproxy.com>
Fri, 10 Feb 2023 15:35:43 +0000 (16:35 +0100)
committerAmaury Denoyelle <adenoyelle@haproxy.com>
Fri, 17 Feb 2023 16:36:30 +0000 (17:36 +0100)
The aim of this function is to rearm the idle timer. The ->expire
field of the timer task was updated without being requeued.
Some connection could be unexpectedly terminated.

Must be backported to 2.6 and 2.7.

src/quic_conn.c

index a44c28d05778417a6c5d9ba068de211cedc2c074..cbead1231e553c91a2e757d9da3b7ebffb6c4d17 100644 (file)
@@ -5221,6 +5221,7 @@ static void qc_idle_timer_do_rearm(struct quic_conn *qc)
 
        expire = QUIC_MAX(3 * quic_pto(qc), qc->max_idle_timeout);
        qc->idle_timer_task->expire = tick_add(now_ms, MS_TO_TICKS(expire));
+       task_queue(qc->idle_timer_task);
 }
 
 /* Rearm the idle timer for <qc> QUIC connection depending on <read> boolean