parser_bison: fix memleak in meta set error handling

We must release the expression here, found via afl++ and
-fsanitize-address build.

Signed-off-by: Florian Westphal <fw@strlen.de>

diff --git a/src/parser_bison.y b/src/parser_bison.y
index 64946a43f93eb3feb1b77417b24f8dd996b3027a..70acfc5754fa232c6f3bf690087b47c81a30e546 100644 (file)
--- a/src/parser_bison.y
+++ b/src/parser_bison.y
@@ -5331,6 +5331,7 @@ meta_stmt         :       META    meta_key        SET     stmt_expr       close_scope_meta
                                free_const($2);
                                if (erec != NULL) {
                                        erec_queue(erec, state->msgs);
+                                       expr_free($4);
                                        YYERROR;
                                }
 

diff --git a/tests/shell/testcases/bogons/nft-f/memleak_on_meta_set_errpath b/tests/shell/testcases/bogons/nft-f/memleak_on_meta_set_errpath
new file mode 100644 (file)
index 0000000..917e8bf
--- /dev/null
+++ b/tests/shell/testcases/bogons/nft-f/memleak_on_meta_set_errpath
@@ -0,0 +1,5 @@
+table filter {
+ chain y {
+  meta seccark set ct secmark
+ }
+}