Bug 2655: passing wrong the username to the url_rewrite_program

diff --git a/src/redirect.cc b/src/redirect.cc
index 6b827ef532deb2bce1d908a63840629af905e529..05d36f4061837371d6120340bb45a2abde6fd949 100644 (file)
--- a/src/redirect.cc
+++ b/src/redirect.cc
@@ -154,7 +154,8 @@ redirectStart(ClientHttpRequest * http, RH * handler, void *data)
     }
 #endif
 
-    if (!r->client_ident && http->request->extacl_user.defined()) {
+    // HttpRequest initializes with null_string. So we must check both defined() and size()
+    if (!r->client_ident && http->request->extacl_user.defined() && http->request->extacl_user.size()) {
         r->client_ident = http->request->extacl_user.termedBuf();
         debugs(61, 5, HERE << "acl-user=" << (r->client_ident?r->client_ident:"NULL"));
     }