]> git.ipfire.org Git - thirdparty/suricata.git/commitdiff
libsuricata-config: fix static library dependency order
authorJason Ish <jason.ish@oisf.net>
Mon, 28 Apr 2025 18:20:38 +0000 (12:20 -0600)
committerVictor Julien <victor@inliniac.net>
Wed, 30 Apr 2025 20:22:25 +0000 (22:22 +0200)
When static linking we have a circular dependency between
libsuricata_rust, and libsuricata_c, so we have to list each twice.

An alternative is to use "-Wl,--start-group", but that isn't portable
outside the GNU toolchain.

libsuricata-config.in

index f03e3b34878fc54e88023d537b6c7d219ee8112b..85cc098a1906548da50690e8a87a4f0f766e5ebc 100644 (file)
@@ -6,8 +6,12 @@ includedir="@includedir@"
 libdir="@libdir@"
 LIBS="@LIBS@ @RUST_LDADD@"
 
+# Shared library to link to (the default).
 shared_lib="-lsuricata"
-static_lib="-lsuricata_c -lsuricata_rust"
+
+# Static libraries to link to. We duplicate these as there are
+# circular references and --start-group is not portable.
+static_lib="-lsuricata_c -lsuricata_rust -lsuricata_c -lsuricata_rust"
 
 lib="$shared_lib"