]> git.ipfire.org Git - thirdparty/sqlalchemy/alembic.git/commitdiff
dont duplicate ModelOne; block A005
authorMike Bayer <mike_mp@zzzcomputing.com>
Wed, 17 Apr 2024 17:21:16 +0000 (13:21 -0400)
committerMike Bayer <mike_mp@zzzcomputing.com>
Wed, 17 Apr 2024 18:24:57 +0000 (14:24 -0400)
this is already in the fixtures.  block new flake8 A005
warning nobody asked for

Change-Id: Ic4f3ec3d1eee5333edb3f48ac95b09ad1b8fdbdf

setup.cfg
tests/test_autogen_diffs.py

index 3c516430571b9d1a086ee8cf9323910ffee589b4..70daeaddcc324c3373734df4ebfd17d1c15ecce3 100644 (file)
--- a/setup.cfg
+++ b/setup.cfg
@@ -84,7 +84,7 @@ where = tests
 enable-extensions = G
 # E203 is due to https://github.com/PyCQA/pycodestyle/issues/373
 ignore =
-    A003,
+    A003,A005
     D,
     E203,E305,E704,E711,E712,E721,E722,E741,
     N801,N802,N806,
index b0490f9e76f109cf302f93380656a1f1fb8406b3..174cfac511acc0db27cd20187eea04ca42051415 100644 (file)
@@ -55,6 +55,7 @@ from alembic.testing.suite._autogen_fixtures import _default_name_filters
 from alembic.testing.suite._autogen_fixtures import _default_object_filters
 from alembic.testing.suite._autogen_fixtures import AutogenFixtureTest
 from alembic.testing.suite._autogen_fixtures import AutogenTest
+from alembic.testing.suite._autogen_fixtures import ModelOne
 from alembic.util import CommandError
 
 # TODO: we should make an adaptation of CompareMetadataToInspectorTest that is
@@ -315,104 +316,6 @@ class AutogenDefaultSchemaIsNoneTest(AutogenFixtureTest, TestBase):
         eq_(len(diffs), 0)
 
 
-class ModelOne:
-    __requires__ = ("unique_constraint_reflection",)
-
-    schema = None
-
-    @classmethod
-    def _get_db_schema(cls):
-        schema = cls.schema
-
-        m = MetaData(schema=schema)
-
-        Table(
-            "user",
-            m,
-            Column("id", Integer, primary_key=True),
-            Column("name", String(50)),
-            Column("a1", Text),
-            Column("pw", String(50)),
-            Index("pw_idx", "pw"),
-        )
-
-        Table(
-            "address",
-            m,
-            Column("id", Integer, primary_key=True),
-            Column("email_address", String(100), nullable=False),
-        )
-
-        Table(
-            "order",
-            m,
-            Column("order_id", Integer, primary_key=True),
-            Column(
-                "amount",
-                Numeric(8, 2),
-                nullable=False,
-                server_default=text("0"),
-            ),
-            CheckConstraint("amount >= 0", name="ck_order_amount"),
-        )
-
-        Table(
-            "extra",
-            m,
-            Column("x", CHAR),
-            Column("uid", Integer, ForeignKey("user.id")),
-        )
-
-        return m
-
-    @classmethod
-    def _get_model_schema(cls):
-        schema = cls.schema
-
-        m = MetaData(schema=schema)
-
-        Table(
-            "user",
-            m,
-            Column("id", Integer, primary_key=True),
-            Column("name", String(50), nullable=False),
-            Column("a1", Text, server_default="x"),
-        )
-
-        Table(
-            "address",
-            m,
-            Column("id", Integer, primary_key=True),
-            Column("email_address", String(100), nullable=False),
-            Column("street", String(50)),
-            UniqueConstraint("email_address", name="uq_email"),
-        )
-
-        Table(
-            "order",
-            m,
-            Column("order_id", Integer, primary_key=True),
-            Column(
-                "amount",
-                Numeric(10, 2),
-                nullable=True,
-                server_default=text("0"),
-            ),
-            Column("user_id", Integer, ForeignKey("user.id")),
-            CheckConstraint("amount > -1", name="ck_order_amount"),
-        )
-
-        Table(
-            "item",
-            m,
-            Column("id", Integer, primary_key=True),
-            Column("description", String(100)),
-            Column("order_id", Integer, ForeignKey("order.order_id")),
-            CheckConstraint("len(description) > 5"),
-        )
-        return m
-
-
 class AutogenerateDiffTest(ModelOne, AutogenTest, TestBase):
     __only_on__ = "sqlite"