Don't load module.la from current directory by default.

* libltdl/ltdl.c (try_dlopen): Do not attempt to load an
unqualified module.la file from the current directory (by
default) since doing so is insecure and is not compliant with
the documentation.
* tests/testsuite.at: Qualify access to module.la file in
current directory so that test passes.

diff --git a/ChangeLog b/ChangeLog
index 8517147407d1151685dd35c6ff546d1d88777db9..bf52f46b0819c1150713be7ad6e1e799cdab39cd 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,13 @@
+2009-11-14  Bob Friesenhahn  <bfriesen@simple.dallas.tx.us>
+
+       Don't load module.la from current directory by default.
+       * libltdl/ltdl.c (try_dlopen): Do not attempt to load an
+       unqualified module.la file from the current directory (by
+       default) since doing so is insecure and is not compliant with
+       the documentation.
+       * tests/testsuite.at: Qualify access to module.la file in
+       current directory so that test passes.
+
 2009-11-14  Peter O'Gorman  <peter@pogma.com>
 
        Only use preopen loader to load preopened archives

diff --git a/libltdl/ltdl.c b/libltdl/ltdl.c
index 1ce4479b0bfd8577327e6b6d712b9e8bd320e303..7c426351c7cdcf721764f8122569ea70052e518d 100644 (file)
--- a/libltdl/ltdl.c
+++ b/libltdl/ltdl.c
@@ -1346,7 +1346,7 @@ try_dlopen (lt_dlhandle *phandle, const char *filename, const char *ext,
            }
 #endif
        }
-      if (!file)
+      else
        {
          file = fopen (attempt, LT_READTEXT_MODE);
        }

diff --git a/tests/testsuite.at b/tests/testsuite.at
index 5037d1429dd685e5a433c87cb02161ce6e9692c1..c5898fdcddb616b1774ce204e9fba346d99b28cf 100644 (file)
--- a/tests/testsuite.at
+++ b/tests/testsuite.at
@@ -288,9 +288,9 @@ main ()
     return 1;
   }
 
-  module = lt_dlopen("module.la");
+  module = lt_dlopen("./module.la");
   if (!module) {
-    fprintf (stderr, "error dlopening module.la: %s\n", lt_dlerror());
+    fprintf (stderr, "error dlopening ./module.la: %s\n", lt_dlerror());
     goto finish;
   }