]> git.ipfire.org Git - thirdparty/rrdtool-1.x.git/commitdiff
src/rrd_modify.c: fix Coverity CID#32405 Logically dead code
authorMarek Schimara <Marek.Schimara@bull.net>
Wed, 15 Jun 2016 13:53:52 +0000 (15:53 +0200)
committerMarek Schimara <Marek.Schimara@bull.net>
Thu, 23 Jun 2016 14:32:33 +0000 (16:32 +0200)
        CWE-561 / https://cwe.mitre.org/data/definitions/561.html

src/rrd_modify.c

index a6a5033fce274d8c5fc9c0450114b27b89741077..369d7a1f5ecf788b5d97e8a92bb147bc0c63cc93 100644 (file)
@@ -1024,11 +1024,6 @@ static void prepare_CDPs(const rrd_t *in, rrd_t *out,
     candidate_t *chosen_candidate = NULL;
     candidate_extra_t junk;
     
-    if (candidates) {
-       free(candidates);
-       candidates = NULL;
-    }
-
     candidates = find_candidate_rras(in, rra_def, &candidates_cnt, junk, select_for_modify);
 
     if (candidates != NULL) {