]> git.ipfire.org Git - thirdparty/util-linux.git/commitdiff
sfdisk: do not free device name too soon [coverity scan]
authorSami Kerola <kerolasa@iki.fi>
Sun, 9 Aug 2020 12:58:10 +0000 (13:58 +0100)
committerKarel Zak <kzak@redhat.com>
Fri, 13 Nov 2020 11:30:12 +0000 (12:30 +0100)
Fixes use after free error.

CID: 360798
Signed-off-by: Sami Kerola <kerolasa@iki.fi>
disk-utils/sfdisk.c

index 54d3b60e71fa954f62e775f7c6c6ee94593c2750..2e9e7cd74c09dc5001f7ff41489dd199402347df 100644 (file)
@@ -619,7 +619,6 @@ done:
        if (f)
                fclose(f);
        free(buf);
-       free(devname);
        free(typescript);
 
        if (sf->noact)
@@ -630,6 +629,8 @@ done:
        } else if (rc)
                warn(_("%s: failed to move data"), devname);
 
+       free(devname);
+
        return rc;
 }