test: add tests in `test_requests` (#2677)

* test: add tests in test_requests

* test: add test for Request.close method

* fix: typo

* test: ignore conditional branch in coverage report and remove unnecessary test

* test: pragma no branch

---------

Co-authored-by: Marcelo Trylesinski <marcelotryle@gmail.com>

diff --git a/starlette/requests.py b/starlette/requests.py
index 23f8ac70a00d294237a55f4ba90f057e5360857b..26c13d1cab4448e556f5da251b5173d85c2d7fee 100644 (file)
--- a/starlette/requests.py
+++ b/starlette/requests.py
@@ -93,7 +93,7 @@ class HTTPConnection(typing.Mapping[str, typing.Any]):
 
     @property
     def url(self) -> URL:
-        if not hasattr(self, "_url"):
+        if not hasattr(self, "_url"):  # pragma: no branch
             self._url = URL(scope=self.scope)
         return self._url
 
@@ -122,7 +122,7 @@ class HTTPConnection(typing.Mapping[str, typing.Any]):
 
     @property
     def query_params(self) -> QueryParams:
-        if not hasattr(self, "_query_params"):
+        if not hasattr(self, "_query_params"):  # pragma: no branch
             self._query_params = QueryParams(self.scope["query_string"])
         return self._query_params
 
@@ -237,7 +237,7 @@ class Request(HTTPConnection):
         return self._body
 
     async def json(self) -> typing.Any:
-        if not hasattr(self, "_json"):
+        if not hasattr(self, "_json"):  # pragma: no branch
             body = await self.body()
             self._json = json.loads(body)
         return self._json
@@ -276,7 +276,7 @@ class Request(HTTPConnection):
         return AwaitableOrContextManagerWrapper(self._get_form(max_files=max_files, max_fields=max_fields))
 
     async def close(self) -> None:
-        if self._form is not None:
+        if self._form is not None:  # pragma: no branch
             await self._form.close()
 
     async def is_disconnected(self) -> bool:

diff --git a/tests/test_requests.py b/tests/test_requests.py
index 02f29ee35f2a3a208c355d784bb0b48fbb4ea705..2f173713efc472c97e5456df4e82eb4bcf498651 100644 (file)
--- a/tests/test_requests.py
+++ b/tests/test_requests.py
@@ -425,7 +425,7 @@ def test_cookies_edge_cases(
         # Browsers don't send extra whitespace or semicolons in Cookie headers,
         # but cookie_parser() should parse whitespace the same way
         # document.cookie parses whitespace.
-        # ("  =  b  ;  ;  =  ;   c  =  ;  ", {"": "b", "c": ""}),
+        ("  =  b  ;  ;  =  ;   c  =  ;  ", {"": "b", "c": ""}),
     ],
 )
 def test_cookies_invalid(