]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
s3:conncache: improve debugging for the negative connection cache
authorStefan Metzmacher <metze@samba.org>
Wed, 16 Feb 2022 13:18:20 +0000 (14:18 +0100)
committerJule Anger <janger@samba.org>
Wed, 6 Aug 2025 08:08:10 +0000 (08:08 +0000)
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14981

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
(cherry picked from commit 613ac83fb7666f5b132187d5587053e0d7dcd46d)

source3/libsmb/conncache.c

index 7310b508a3b3f9b5b72733dc5db0281e05d92a18..353c1e8f9305d1f212dafb2dc6f9da29f12bd885 100644 (file)
@@ -147,8 +147,9 @@ NTSTATUS check_negative_conn_cache( const char *domain, const char *server)
        if (gencache_get(key, talloc_tos(), &value, NULL))
                result = negative_conn_cache_valuedecode(value);
  done:
-       DEBUG(9,("check_negative_conn_cache returning result %d for domain %s "
-                 "server %s\n", NT_STATUS_V(result), domain, server));
+       DBG_PREFIX(NT_STATUS_IS_OK(result) ? DBGLVL_DEBUG : DBGLVL_INFO,
+                  ("returning result %s for domain %s "
+                   "server %s\n", nt_errstr(result), domain, server));
        TALLOC_FREE(key);
        TALLOC_FREE(value);
        return result;
@@ -187,7 +188,8 @@ void add_failed_connection_entry(const char *domain, const char *server,
        if (gencache_set(key, value,
                         time(NULL) + FAILED_CONNECTION_CACHE_TIMEOUT))
                DEBUG(9,("add_failed_connection_entry: added domain %s (%s) "
-                         "to failed conn cache\n", domain, server ));
+                         "to failed conn cache %s\n", domain, server,
+                        nt_errstr(result)));
        else
                DEBUG(1,("add_failed_connection_entry: failed to add "
                          "domain %s (%s) to failed conn cache\n",