]> git.ipfire.org Git - thirdparty/Python/cpython.git/commitdiff
gh-89898: Fix test_threading.test_args_argument() (GH-92885)
authorMiss Islington (bot) <31488909+miss-islington@users.noreply.github.com>
Tue, 17 May 2022 22:45:56 +0000 (15:45 -0700)
committerGitHub <noreply@github.com>
Tue, 17 May 2022 22:45:56 +0000 (15:45 -0700)
Join the thread to not leak threads running in the background to the
next test.

Fix the following warning on the "AMD64 FreeBSD Shared 3.11"
buildbot:

test_args_argument (test.test_threading.ThreadTests.test_args_argument) ...
Warning -- threading_cleanup() failed to cleanup 1 threads (count: 1, dangling: 2)
Warning -- Dangling thread: <_MainThread(MainThread, started 35026161664)>
Warning -- Dangling thread: <Thread(Thread-134 (<lambda>), started 35314998016)>
ok
(cherry picked from commit 970efae274538f9910e8f9b31bc890f1b7666b0f)

Co-authored-by: Victor Stinner <vstinner@python.org>
Lib/test/test_threading.py

index f7dea136a87c0d23836072f1c27d7aea41c7d7f8..9c6561c099f57082d193f9c048fc2bb90ebcba3a 100644 (file)
@@ -149,6 +149,7 @@ class ThreadTests(BaseTestCase):
             with self.subTest(target=target, args=args):
                 t = threading.Thread(target=target, args=args)
                 t.start()
+                t.join()
 
     @cpython_only
     def test_disallow_instantiation(self):