]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
drm/i915/display: Set C10_VDR_CTRL_MSGBUS_ACCESS before phy reg read
authorJouni Högander <jouni.hogander@intel.com>
Tue, 22 Jul 2025 12:56:18 +0000 (15:56 +0300)
committerTvrtko Ursulin <tursulin@ursulin.net>
Tue, 29 Jul 2025 09:20:33 +0000 (10:20 +0100)
According to C10 VDR Register programming sequence we need set
C10_VDR_CTRL_MSGBUS_ACCESS before accessing PHY internal registers from
MsgBus.

v2: set C10_VDR_CTRL_MSGBUS_ACCESS once for all owned lanes

Bspec: 68962
Fixes: 9dc619680de4 ("drm/i915/display: Add function to configure LFPS sending")
Suggested-by: Gustavo Sousa <gustavo.sousa@intel.com>
Signed-off-by: Jouni Högander <jouni.hogander@intel.com>
Reviewed-by: Gustavo Sousa <gustavo.sousa@intel.com>
Link: https://lore.kernel.org/r/20250722125618.1842615-5-jouni.hogander@intel.com
(cherry picked from commit 8921dce70d46e3156b5a0b21675f5ac90903d81d)
Signed-off-by: Tvrtko Ursulin <tursulin@ursulin.net>
drivers/gpu/drm/i915/display/intel_cx0_phy.c

index a203937d66dbedf1e7c69c6fe124249ceed5d4c6..801235a5bc0a3e1f88aa21fa10650e33a95cf1b8 100644 (file)
@@ -3251,6 +3251,10 @@ void intel_lnl_mac_transmit_lfps(struct intel_encoder *encoder,
 
        wakeref = intel_cx0_phy_transaction_begin(encoder);
 
+       if (intel_encoder_is_c10phy(encoder))
+               intel_cx0_rmw(encoder, owned_lane_mask, PHY_C10_VDR_CONTROL(1), 0,
+                             C10_VDR_CTRL_MSGBUS_ACCESS, MB_WRITE_COMMITTED);
+
        for (i = 0; i < 4; i++) {
                int tx = i % 2 + 1;
                u8 lane_mask = i < 2 ? INTEL_CX0_LANE0 : INTEL_CX0_LANE1;