]> git.ipfire.org Git - thirdparty/qemu.git/commitdiff
tests/qemu-iotests/tests/mirror-sparse: actually require O_DIRECT
authorMichael Tokarev <mjt@tls.msk.ru>
Wed, 6 Aug 2025 07:48:37 +0000 (10:48 +0300)
committerMichael Tokarev <mjt@tls.msk.ru>
Thu, 7 Aug 2025 20:55:39 +0000 (23:55 +0300)
Commit c0ddcb2cbc146e introduced the test which uses cache=direct
mode, without checking if the scratch filesystem supports O_DIRECT.
A subsequent commit, afeb002e0ad49d, tried to fix that issue, but
instead of checking for o_direct, it checked for
`_supported_cache_modes none directsync`, which is not what the
original mirror-sparse test uses.  Fix both by actually checking
for o_direct.

Fixes: c0ddcb2cbc146e "tests: Add iotest mirror-sparse for recent patches"
Fixes: afeb002e0ad49d "tests/qemu-iotests/tests/mirror-sparse: skip if O_DIRECT is not supported"
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
tests/qemu-iotests/tests/mirror-sparse

index 3b183eea88afd2a899b9c4eb7b233f989f2fec28..ee7101bd50ec89890dc78a194b08fd61b4b6eba3 100755 (executable)
@@ -40,7 +40,7 @@ cd ..
 _supported_fmt qcow2 raw  # Format of the source. dst is always raw file
 _supported_proto file
 _supported_os Linux
-_supported_cache_modes none directsync
+_require_o_direct
 _require_disk_usage
 
 echo