su: (pty) fix slave terminal attributes initialization

Reported-by: Vaclav Dolezal <vdolezal@redhat.com>
Signed-off-by: Karel Zak <kzak@redhat.com>

diff --git a/login-utils/su-common.c b/login-utils/su-common.c
index bfccb4643e446537d17b06a836848ff616eed57c..f873c23bcb8931d2f744697abbf51077fc14c9fd 100644 (file)
--- a/login-utils/su-common.c
+++ b/login-utils/su-common.c
@@ -273,7 +273,7 @@ static void pty_create(struct su_context *su)
                rc = openpty(&su->pty_master, &su->pty_slave, NULL, NULL, NULL);
 
                /* set slave attributes */
-               if (rc < 0) {
+               if (!rc) {
                        tcgetattr(su->pty_slave, &slave_attrs);
                        cfmakeraw(&slave_attrs);
                        tcsetattr(su->pty_slave, TCSANOW, &slave_attrs);