build: --vendor-suffix instead of --vendor-patch-revision --vendor-name

In practice there isn't a use for two options, and neither quite
matched what people thought they were doing.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15673

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Jo Sutton <josutton@catalyst.net.nz>

diff --git a/script/autobuild.py b/script/autobuild.py
index c25fb94b3d5e947e15a8f9803ab8868e5ba9aae3..7d9dc008bcf4c7e2b30144f0b97e1474d473909c 100755 (executable)
--- a/script/autobuild.py
+++ b/script/autobuild.py
@@ -887,10 +887,10 @@ tasks = {
             ("tevent-make", "cd lib/tevent && make"),
             ("tevent-install", "cd lib/tevent && make install"),
 
-            ("nondevel-configure", samba_libs_envvars + " ./configure --private-libraries='!ldb' --vendor-name=autobuild-TEST-STRING --vendor-patch-revision=5 ${PREFIX}"),
+            ("nondevel-configure", samba_libs_envvars + " ./configure --private-libraries='!ldb' --vendor-suffix=TEST-STRING~5.1.2 ${PREFIX}"),
             ("nondevel-make", "make -j"),
             ("nondevel-check", "./bin/smbd -b | grep WITH_NTVFS_FILESERVER && exit 1; exit 0"),
-            ("nondevel-check", "./bin/smbd --version | grep -e '-autobuild-TEST-STRING-5' && exit 0; exit 1"),
+            ("nondevel-check", "./bin/smbd --version | grep -F 'TEST-STRING~5.1.2' && exit 0; exit 1"),
             ("nondevel-no-libtalloc", "find ./bin | grep -v 'libtalloc-report' | grep 'libtalloc' && exit 1; exit 0"),
             ("nondevel-no-libtdb", "find ./bin | grep -v 'libtdb-wrap' | grep 'libtdb' && exit 1; exit 0"),
             ("nondevel-no-libtevent", "find ./bin | grep -v 'libtevent-util' | grep 'libtevent' && exit 1; exit 0"),

diff --git a/wscript b/wscript
index be4f3122af6fb6b610de945e8c061c567d0e00b9..8dd6599cdd7e615392ef6d794450126fb7bb7e68 100644 (file)
--- a/wscript
+++ b/wscript
@@ -162,27 +162,17 @@ def options(opt):
                                dest='with_smb1server',
                                help=("Build smbd with SMB1 support (default=yes)."))
 
-    opt.add_option('--vendor-name',
+    opt.add_option('--vendor-suffix',
                    help=('Specify a vendor (or packager) name to include in the version string'),
                    type="string",
                    dest='SAMBA_VERSION_VENDOR_SUFFIX',
                    default=None)
 
-    opt.add_option('--vendor-patch-revision',
-                   help=('Specify a vendor (or packager) patch revision number include in the version string (requires --vendor-name)'),
-                   type="int",
-                   dest='SAMBA_VERSION_VENDOR_PATCH',
-                   default=None)
 
 def configure(conf):
     if Options.options.SAMBA_VERSION_VENDOR_SUFFIX:
         conf.env.SAMBA_VERSION_VENDOR_SUFFIX = Options.options.SAMBA_VERSION_VENDOR_SUFFIX
 
-    if Options.options.SAMBA_VERSION_VENDOR_PATCH:
-        if not Options.options.SAMBA_VERSION_VENDOR_SUFFIX:
-            raise conf.fatal('--vendor-patch-revision requires --vendor-version')
-        conf.env.SAMBA_VERSION_VENDOR_PATCH = Options.options.SAMBA_VERSION_VENDOR_PATCH
-
     version = samba_version.load_version(env=conf.env)
 
     conf.DEFINE('CONFIG_H_IS_FROM_SAMBA', 1)