]> git.ipfire.org Git - thirdparty/squid.git/commitdiff
ext_lm_group_acl: Improved username handling (#512)
authoraaron-costello <56684862+aaron-costello@users.noreply.github.com>
Fri, 22 Nov 2019 02:44:29 +0000 (02:44 +0000)
committerAmos Jeffries <yadij@users.noreply.github.com>
Fri, 3 Jan 2020 22:38:44 +0000 (11:38 +1300)
src/acl/external/LM_group/ext_lm_group_acl.cc

index dee369ca3d6382118cabbf38ad0b9efc1ed28cd3..a0fb6adec39eb2b05805696d62cccd240f330bf7 100644 (file)
@@ -343,10 +343,10 @@ Valid_Global_Groups(char *UserName, const char **Groups)
             break;
     }
     if (domain_qualify == NULL) {
-        strcpy(User, NTDomain);
-        strcpy(NTDomain, DefaultDomain);
+        xstrncpy(User, NTDomain, sizeof(User));
+        xstrncpy(NTDomain, DefaultDomain, sizeof(NTDomain));
     } else {
-        strcpy(User, domain_qualify + 1);
+        xstrncpy(User, domain_qualify + 1, sizeof(User));
         domain_qualify[0] = '\0';
         strlwr(NTDomain);
     }