- Fix for char signedness warnings on NetBSD.

diff --git a/doc/Changelog b/doc/Changelog
index f1bdd3381f1d16c482ce18d70ef0f4c977afc1f2..a6eb51438f8d76ba2d12d4d98e25081c32f5cad3 100644 (file)
--- a/doc/Changelog
+++ b/doc/Changelog
@@ -1,5 +1,6 @@
 21 August 2024: Wouter
        - Add cross platform freebsd, openbsd and netbsd to github ci.
+       - Fix for char signedness warnings on NetBSD.
 
 20 August 2024: Wouter
        - Add iter-scrub-ns, iter-scrub-cname and max-global-quota

diff --git a/services/modstack.c b/services/modstack.c
index 6c8af0505b69fd70d45b8bbc7d378c96c4efceae..fa68cc71d2ff28b1e30d47aa45ecadcd31b795eb 100644 (file)
--- a/services/modstack.c
+++ b/services/modstack.c
@@ -265,7 +265,7 @@ modstack_call_init(struct module_stack* stack, const char* module_conf,
         int i, changed = 0;
         env->need_to_validate = 0; /* set by module init below */
         for(i=0; i<stack->num; i++) {
-               while(*module_conf && isspace(*module_conf))
+               while(*module_conf && isspace((unsigned char)*module_conf))
                        module_conf++;
                 if(strncmp(stack->mod[i]->name, module_conf,
                        strlen(stack->mod[i]->name))) {

diff --git a/testcode/unitzonemd.c b/testcode/unitzonemd.c
index bf130df5a25b710aecbc2393bdf9018eddeb30b1..9ddf201f98219cab0f3c32ebe30b2e27dabafa68 100644 (file)
--- a/testcode/unitzonemd.c
+++ b/testcode/unitzonemd.c
@@ -108,7 +108,7 @@ static void zonemd_generate_test(const char* zname, char* zfile,
        digestdup = strdup(digest);
        unit_assert(digestdup);
        for(i=0; i<strlen(digestdup); i++) {
-               digestdup[i] = toupper(digestdup[i]);
+               digestdup[i] = toupper((unsigned char)digestdup[i]);
        }
        if(verbosity >= VERB_ALGO) {
                char zname[255+1];

diff --git a/util/config_file.c b/util/config_file.c
index bd6f8f40b58afb9788c63e14a0bc89d6f954f44d..12df8e79348460ef03d1c4ab1d97d2bd5dd17f53 100644 (file)
--- a/util/config_file.c
+++ b/util/config_file.c
@@ -2332,7 +2332,7 @@ uint8_t* cfg_parse_nsid(const char* str, uint16_t* nsid_len)
                uint8_t *dp;
 
                for ( ch = str, dp = nsid
-                   ; isxdigit(ch[0]) && isxdigit(ch[1])
+                   ; isxdigit((unsigned char)ch[0]) && isxdigit((unsigned char)ch[1])
                    ; ch += 2, dp++) {
                        *dp  = (uint8_t)sldns_hexdigit_to_int(ch[0]) * 16;
                        *dp += (uint8_t)sldns_hexdigit_to_int(ch[1]);