]> git.ipfire.org Git - thirdparty/bootstrap.git/commitdiff
Unify `offcanvas` `keydown` event logic with `modal` (#38025)
authorRoni Diwan <ronidiwan@gmail.com>
Sat, 11 Feb 2023 08:35:10 +0000 (10:35 +0200)
committerGitHub <noreply@github.com>
Sat, 11 Feb 2023 08:35:10 +0000 (09:35 +0100)
js/src/modal.js
js/src/offcanvas.js

index 0a38586cefb00bdd0dc96d9429ada1dc5b05df2e..a5adc8466ef74ea9285366ace2be7630eb3a0134 100644 (file)
@@ -208,7 +208,6 @@ class Modal extends BaseComponent {
       }
 
       if (this._config.keyboard) {
-        event.preventDefault()
         this.hide()
         return
       }
index 54adf86ccb9a89fe8a954dcf1b7569c57c91f84e..4d5975c0f6cc9628c5cf4829154406978bc6fac6 100644 (file)
@@ -198,12 +198,12 @@ class Offcanvas extends BaseComponent {
         return
       }
 
-      if (!this._config.keyboard) {
-        EventHandler.trigger(this._element, EVENT_HIDE_PREVENTED)
+      if (this._config.keyboard) {
+        this.hide()
         return
       }
 
-      this.hide()
+      EventHandler.trigger(this._element, EVENT_HIDE_PREVENTED)
     })
   }