Add information about "generation" when dropping twice pgstats entry

Dropping twice a pgstats entry should not happen, and the error report
generated was missing the "generation" counter (tracking when an entry
is reused) that has been added in 818119afccd3.

Like d92573adcb02, backpatch down to v15 where this information is
useful to have, to gather more information from instances where the
problem shows up.  A report has shown that this error path has been
reached on a standby based on 17.3, for a relation stats entry and an
OID close to wraparound.

Author: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
Discussion: https://postgr.es/m/CAN4RuQvYth942J2+FcLmJKgdpq6fE5eqyFvb_PuskxF2eL=Wzg@mail.gmail.com
Backpatch-through: 15

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index dca1a28f486d8711a164bb129d78d1ea49c3a7e4..229333aae450bacb9ad8db90538caeb58733406a 100644 (file)
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -833,10 +833,11 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
         */
        if (shent->dropped)
                elog(ERROR,
-                        "trying to drop stats entry already dropped: kind=%s dboid=%u objoid=%u refcount=%u",
+                        "trying to drop stats entry already dropped: kind=%s dboid=%u objoid=%u refcount=%u generation=%u",
                         pgstat_get_kind_info(shent->key.kind)->name,
                         shent->key.dboid, shent->key.objoid,
-                        pg_atomic_read_u32(&shent->refcount));
+                        pg_atomic_read_u32(&shent->refcount),
+                        pg_atomic_read_u32(&shent->generation));
        shent->dropped = true;
 
        /* release refcount marking entry as not dropped */