]> git.ipfire.org Git - thirdparty/kmod.git/commitdiff
testsuite/modprobe: remove --quiet from --show-{depends,exports}
authorEmil Velikov <emil.l.velikov@gmail.com>
Fri, 30 May 2025 19:10:09 +0000 (20:10 +0100)
committerLucas De Marchi <lucas.de.marchi@gmail.com>
Fri, 13 Jun 2025 18:52:41 +0000 (13:52 -0500)
Even though we don't give the user any feedback, the --quiet option is
only applicable with --remove. Remove it from any modprobe --show*
invocations.

Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
Link: https://github.com/kmod-project/kmod/pull/353
Signed-off-by: Lucas De Marchi <lucas.de.marchi@gmail.com>
testsuite/test-modprobe.c

index ab675ed349895749dfe806934d027d32551db63a..b341f8908c952d3ad9c06c48dbbabd300fbe5b46 100644 (file)
@@ -57,7 +57,7 @@ DEFINE_TEST_WITH_FUNC(modprobe_show_depends_no_load, modprobe_show_depends2,
 
 static noreturn int modprobe_show_alias_to_none(void)
 {
-       EXEC_MODPROBE("--show-depends", "--ignore-install", "--quiet", "mod-simple");
+       EXEC_MODPROBE("--show-depends", "--ignore-install", "mod-simple");
        exit(EXIT_FAILURE);
 }
 DEFINE_TEST(modprobe_show_alias_to_none,
@@ -74,7 +74,7 @@ DEFINE_TEST(modprobe_show_alias_to_none,
 
 static noreturn int modprobe_show_exports(void)
 {
-       EXEC_MODPROBE("--show-exports", "--quiet", "/mod-loop-a.ko");
+       EXEC_MODPROBE("--show-exports", "/mod-loop-a.ko");
        exit(EXIT_FAILURE);
 }
 DEFINE_TEST(modprobe_show_exports,