]> git.ipfire.org Git - thirdparty/haproxy.git/commitdiff
BUILD: quic: fix a build error about an non initialized timestamp
authorFrederic Lecaille <flecaille@haproxy.com>
Fri, 29 Nov 2024 13:39:48 +0000 (14:39 +0100)
committerFrederic Lecaille <flecaille@haproxy.com>
Fri, 29 Nov 2024 13:48:37 +0000 (14:48 +0100)
This is to please a non identified compilers which complains about an hypothetic
<time_ns> variable which would be not initialized even if this is the case only
when it is not used.

This build issue arrived with this commit:
BUG/MINOR: improve BBR throughput on very fast links

Should be backported to 3.1 with this previous commit.

src/quic_rx.c

index b675e720b8574dfa3e8055065910b928902cb067..b333c13ff96b1d9acd1233ef80013499a3816ed2 100644 (file)
@@ -432,13 +432,10 @@ static void qc_notify_cc_of_newly_acked_pkts(struct quic_conn *qc,
        struct quic_cc_drs *drs =
                p->cc.algo->get_drs ? p->cc.algo->get_drs(&p->cc) : NULL;
        unsigned int bytes_delivered = 0, pkt_delivered = 0;
-       uint64_t time_ns;
+       uint64_t time_ns = task_mono_time();
 
        TRACE_ENTER(QUIC_EV_CONN_PRSAFRM, qc);
 
-       if (drs)
-               time_ns = task_mono_time();
-
        list_for_each_entry_safe(pkt, tmp, newly_acked_pkts, list) {
                pkt->pktns->tx.in_flight -= pkt->in_flight_len;
                p->prep_in_flight -= pkt->in_flight_len;