]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
s4:torture: Initialize struct wrepl_wins_name
authorAndreas Schneider <asn@samba.org>
Mon, 24 Jun 2024 10:22:19 +0000 (12:22 +0200)
committerAndreas Schneider <asn@cryptomilk.org>
Fri, 28 Jun 2024 11:39:33 +0000 (11:39 +0000)
"Error: UNINIT (CWE-457):
samba-4.20.0rc2/source4/torture/nbt/winsreplication.c:6759: var_decl: Declaring variable ""wins_name_"" without initializer.
samba-4.20.0rc2/source4/torture/nbt/winsreplication.c:6760: assign: Assigning: ""wins_name"" = ""&wins_name_"", which points to uninitialized data.
samba-4.20.0rc2/source4/torture/nbt/winsreplication.c:9455: uninit_use_in_call: Using uninitialized value ""*wins_name"". Field ""wins_name->is_group"" is uninitialized when calling ""test_wrepl_update_one"".
 9453|    wins_name->unknown = ""255.255.255.255"";
 9454|
 9455|->  ret &= test_wrepl_update_one(tctx, ctx, &ctx->b, wins_name);
 9456|
 9457|    /*"

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Noel Power <npower@samba.org>
source4/torture/nbt/winsreplication.c

index 90004cabe63614da94d2f005fd198025eecf89f8..2bfdb84daed308d7926a9e607bfa48043a562f40 100644 (file)
@@ -6758,7 +6758,9 @@ static bool test_conflict_owned_active_vs_replica(struct torture_context *tctx,
 {
        bool ret = true;
        NTSTATUS status;
-       struct wrepl_wins_name wins_name_;
+       struct wrepl_wins_name wins_name_ = {
+               .flags = 0,
+       };
        struct wrepl_wins_name *wins_name = &wins_name_;
        struct nbt_name_register name_register_;
        struct nbt_name_register *name_register = &name_register_;