]> git.ipfire.org Git - thirdparty/rrdtool-1.x.git/commitdiff
Issue #1101 Do not leak filename opening a broken file
authorOndřej Kuzník <ondra@mistotebe.net>
Fri, 12 Mar 2021 13:27:06 +0000 (13:27 +0000)
committerOndřej Kuzník <ondra@mistotebe.net>
Fri, 12 Mar 2021 13:27:06 +0000 (13:27 +0000)
src/rrd_daemon.c

index c04829fb4645cf85fd0f4e87ba1598e72268c24b..60abe58d290d45f95ba7d07b5f508a4ce5a6695b 100644 (file)
@@ -1678,6 +1678,7 @@ static int handle_request_update(
         rrd_file = rrd_open(file, &rrd, RRD_READONLY | RRD_LOCK);
         if (!rrd_file) {
             rrd_free(&rrd);
+            free(ci->file);
             free(ci);
             RRDD_LOG(LOG_ERR,
                      "handle_request_update: Could not read RRD file.");
@@ -1693,6 +1694,7 @@ static int handle_request_update(
         ci->last_update_stamp = last_update_from_file;
 
         if (ci->last_update_stamp < 1) {
+            free(ci->file);
             free(ci);
             RRDD_LOG(LOG_ERR,
                      "handle_request_update: Invalid timestamp from RRD file.");