smbd: Simplify dos_mode_from_sbuf

We don't need that else branch, this could be a switch as well

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>

diff --git a/source3/smbd/dosmode.c b/source3/smbd/dosmode.c
index 51d9c0508fe4a8fa5e6faa3a93db584dad04d60a..796cd39626b3b1cf28041fa8b107a82685e430cd 100644 (file)
--- a/source3/smbd/dosmode.c
+++ b/source3/smbd/dosmode.c
@@ -215,13 +215,14 @@ static uint32_t dos_mode_from_sbuf(connection_struct *conn,
                if ((st->st_ex_mode & S_IWUSR) == 0) {
                        result |= FILE_ATTRIBUTE_READONLY;
                }
-       } else if (ro_opts == MAP_READONLY_PERMISSIONS) {
+       }
+       if (ro_opts == MAP_READONLY_PERMISSIONS) {
                /* smb_fname->fsp can be NULL for an MS-DFS link. */
                /* Check actual permissions for read-only. */
                if ((fsp != NULL) && !can_write_to_fsp(fsp)) {
                        result |= FILE_ATTRIBUTE_READONLY;
                }
-       } /* Else never set the readonly bit. */
+       }
 
        if (MAP_ARCHIVE(conn) && ((st->st_ex_mode & S_IXUSR) != 0)) {
                result |= FILE_ATTRIBUTE_ARCHIVE;