[#51] Fixed a syntax error in ldap.c

server/ldap.c - fixed invalid compare to "\0"

added a release note

diff --git a/RELNOTES b/RELNOTES
index ba9324bd04ee233905a58497437dcc1d4794e4f6..a53c55b642f67f59b5f310f71293bfae70937238 100644 (file)
--- a/RELNOTES
+++ b/RELNOTES
@@ -199,6 +199,10 @@ by Eric Young (eay@cryptsoft.com).
   source.
   [Gitlab #35]
 
+- Fixed a syntax error in ldap.c which cropped up under Ubuntu
+  18.04.1/gcc 7.4.0. Thanks to Charles Hedrick for pointing it out.
+  [Gitlab #51]
+
                Changes since 4.4.0 (New Features)
 - none
                Changes since 4.4.0 (Bug Fixes)

diff --git a/server/ldap.c b/server/ldap.c
index 5126d24a6619149bf5476acc26c46225ba7f4cb8..46b13d00e02503ae2cb65eff7eac2ae7ed9c79e4 100644 (file)
--- a/server/ldap.c
+++ b/server/ldap.c
@@ -925,7 +925,7 @@ ldap_parse_failover (struct ldap_config_stack *item, struct parse *cfile)
     ldap_value_free_len (tempbv);
 
 
-  if (primary == -1 || srvaddr[0] == '\0' || srvaddr[1] == '\0')
+  if (primary == -1 || *srvaddr[0] == '\0' || *srvaddr[1] == '\0')
     {
       log_error("Could not decide if the server type is primary"
                 " or secondary for failover peering '%s'.", peername[0]->bv_val);