res_fax: Resolve module reference leak caused by reserved sessions

Remove reference to module providing reserved session after
adding a reference to the final module.  This re-reference
is done to ensure that module references are correct even
if the final session selects a different module than the
reserved session.

ASTERISK-18923 #close
Reported by: Grigoriy Puzankin
Review: https://reviewboard.asterisk.org/r/4048/

git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@425405 65c4cc65-6c06-0410-ace0-fbb531ad65f3

diff --git a/res/res_fax.c b/res/res_fax.c
index 0b7e69bdc5ddbe7a69a19d5b1dcd3a261928b650..2da4e9f06ba987fe39658c1e818acbbccc34cb12 100644 (file)
--- a/res/res_fax.c
+++ b/res/res_fax.c
@@ -873,6 +873,10 @@ static struct ast_fax_session *fax_session_new(struct ast_fax_session_details *d
                        }
                        ast_debug(4, "Requesting a new FAX session from '%s'.\n", faxmod->tech->description);
                        ast_module_ref(faxmod->tech->module);
+                       if (reserved) {
+                               /* Balance module ref from reserved session */
+                               ast_module_unref(reserved->tech->module);
+                       }
                        s->tech = faxmod->tech;
                        break;
                }