fs/proc: do_task_stat: use __for_each_thread()

commit 7904e53ed5a20fc678c01d5d1b07ec486425bb6a upstream.

do/while_each_thread should be avoided when possible.

Link: https://lkml.kernel.org/r/20230909164501.GA11581@redhat.com
Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Cc: Eric W. Biederman <ebiederm@xmission.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Stable-dep-of: 7601df8031fd ("fs/proc: do_task_stat: use sig->stats_lock to gather the threads/children stats")
Cc: stable@vger.kernel.org
[ mheyne: adjusted context ]
Signed-off-by: Maximilian Heyne <mheyne@amazon.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/fs/proc/array.c b/fs/proc/array.c
index 8fba6d39e776fde22d7bd81bdcd733a677e96676..77b94c04e4aff76feef3aad33faee77f286e0503 100644 (file)
--- a/fs/proc/array.c
+++ b/fs/proc/array.c
@@ -512,18 +512,18 @@ static int do_task_stat(struct seq_file *m, struct pid_namespace *ns,
                cgtime = sig->cgtime;
 
                if (whole) {
-                       struct task_struct *t = task;
+                       struct task_struct *t;
 
                        min_flt = sig->min_flt;
                        maj_flt = sig->maj_flt;
                        gtime = sig->gtime;
 
                        rcu_read_lock();
-                       do {
+                       __for_each_thread(sig, t) {
                                min_flt += t->min_flt;
                                maj_flt += t->maj_flt;
                                gtime += task_gtime(t);
-                       } while_each_thread(task, t);
+                       }
                        rcu_read_unlock();
 
                        thread_group_cputime_adjusted(task, &utime, &stime);