]> git.ipfire.org Git - thirdparty/libcgroup.git/commitdiff
api.c: Preserve dirty flag when copying controller values
authorNikola Forró <nforro@redhat.com>
Thu, 16 Jan 2020 17:43:51 +0000 (18:43 +0100)
committerTom Hromatka <tom.hromatka@oracle.com>
Fri, 31 Jan 2020 20:59:43 +0000 (20:59 +0000)
When setting cgroup parameters with cgset fails, no error is reported.
This is caused by the fact that cgroup_copy_controller_values is not
preserving dirty flags of the values, so it's making all errors
considered non-fatal.

Signed-off-by: Nikola Forró <nforro@redhat.com>
Reviewed-by: Tom Hromatka <tom.hromatka@oracle.com>
src/api.c

index 959a814092e7e0a64aaef02e32f6ec8ec341e65f..e7a07cfc5fe7968446f63e857a8a9f2f46fef51d 100644 (file)
--- a/src/api.c
+++ b/src/api.c
@@ -1751,6 +1751,7 @@ static int cgroup_copy_controller_values(struct cgroup_controller *dst,
                dst_val = dst->values[i];
                strncpy(dst_val->value, src_val->value, CG_VALUE_MAX);
                strncpy(dst_val->name, src_val->name, FILENAME_MAX);
+               dst_val->dirty = src_val->dirty;
        }
 err:
        return ret;