]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
iio: hid-sensor-prox: Fix incorrect OFFSET calculation
authorZhang Lixu <lixu.zhang@intel.com>
Thu, 24 Jul 2025 15:19:22 +0000 (11:19 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 1 Aug 2025 08:48:47 +0000 (09:48 +0100)
[ Upstream commit 79dabbd505210e41c88060806c92c052496dd61c ]

The OFFSET calculation in the prox_read_raw() was incorrectly using the
unit exponent, which is intended for SCALE calculations.

Remove the incorrect OFFSET calculation and set it to a fixed value of 0.

Cc: stable@vger.kernel.org
Fixes: 39a3a0138f61 ("iio: hid-sensors: Added Proximity Sensor Driver")
Signed-off-by: Zhang Lixu <lixu.zhang@intel.com>
Acked-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Link: https://patch.msgid.link/20250331055022.1149736-4-lixu.zhang@intel.com
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
[ adapted prox_attr array access to single structure member access ]
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/iio/light/hid-sensor-prox.c

index a54e3c87cee31b9cf0462d8729718756c0a0064a..25901d91a613f40995f05409cdd8c1788b1b9aed 100644 (file)
@@ -102,8 +102,7 @@ static int prox_read_raw(struct iio_dev *indio_dev,
                ret_type = prox_state->scale_precision;
                break;
        case IIO_CHAN_INFO_OFFSET:
-               *val = hid_sensor_convert_exponent(
-                               prox_state->prox_attr.unit_expo);
+               *val = 0;
                ret_type = IIO_VAL_INT;
                break;
        case IIO_CHAN_INFO_SAMP_FREQ: