maintcheck: placate maintainer-check and grep 3.8.

* maintainer/syntax-checks.mk (sc_rm_minus_f): no \ before -
(diagnosed by grep 3.8).
* t/comment12.sh: use $(...) instead of `...`.
* t/comments-escaped-in-var.sh: use AUTOMAKE_fails and grep
for expected warning message.
* t/list-of-tests.mk (handwritten_TESTS): add t/py-compile-files.sh.
* t/subdir-add2-pr46.sh (.NOTPARALLEL): add; showed up with
parallelized internal make. Seems unreproducible.

diff --git a/maintainer/syntax-checks.mk b/maintainer/syntax-checks.mk
index e071451c83721b10632c1b3ddd699c429daf351d..7cd6d198a90bbd74551a023eac6aecb00ef4e4e6 100644 (file)
--- a/maintainer/syntax-checks.mk
+++ b/maintainer/syntax-checks.mk
@@ -150,7 +150,7 @@ sc_no_brace_variable_expansions:
 sc_rm_minus_f:
        @if grep -v '^#' $(ams) $(xtests) \
           | grep -vE '/(rm-f-probe\.sh|spy-rm\.tap|subobj-clean.*-pr10697\.sh):' \
-          | grep -E '\<rm ([^-]|\-[^f ]*\>)'; \
+          | grep -E '\<rm ([^-]|-[^f ]*\>)'; \
        then \
          echo "Suspicious 'rm' invocation." 1>&2; \
          exit 1; \

diff --git a/t/comment12.sh b/t/comment12.sh
index e98159e40f3ef276c7c8faa2c506665a450095d1..3653126f4dc78f38757e26c043e67454ffe7a80b 100644 (file)
--- a/t/comment12.sh
+++ b/t/comment12.sh
@@ -40,5 +40,5 @@ $AUTOMAKE
 # For debugging.
 grep '^VAR' Makefile.in
 
-count=`grep '^VAR. = val$' Makefile.in | wc -l`
+count=$(grep '^VAR. = val$' Makefile.in | wc -l)
 [ $count -eq 6 ]

diff --git a/t/comments-escaped-in-var.sh b/t/comments-escaped-in-var.sh
index e06c3f359b6889bd1c17150d108023efcd54ef75..75c01a7026ead2f32179d1bffbcc7be9d4300f68 100644 (file)
--- a/t/comments-escaped-in-var.sh
+++ b/t/comments-escaped-in-var.sh
@@ -30,8 +30,11 @@ END
 
 $ACLOCAL
 
-# This should fail due to -Werror.
-$AUTOMAKE && exit 1
+# This should fail due to -Werror, as in:
+#   automake-1.16: warnings are treated as errors
+#   Makefile.am:2: warning: escaping \# comment markers is not portable
+AUTOMAKE_fails
+grep 'escaping.*comment markers.*portable' stderr
 
 # This should pass though.
 $AUTOMAKE -Wno-portability

diff --git a/t/list-of-tests.mk b/t/list-of-tests.mk
index 0af117a5a5959bd39131e302f546466e7812e6e7..d82cf9c4d667c450ab5c0d4b3e3e21288b0da54f 100644 (file)
--- a/t/list-of-tests.mk
+++ b/t/list-of-tests.mk
@@ -921,6 +921,7 @@ t/py-compile-basic.sh \
 t/py-compile-basedir.sh \
 t/py-compile-destdir.sh \
 t/py-compile-env.sh \
+t/py-compile-files.sh \
 t/py-compile-option-terminate.sh \
 t/py-compile-usage.sh \
 t/python.sh \

diff --git a/t/subdir-add2-pr46.sh b/t/subdir-add2-pr46.sh
index 813868ac72c20ba7079aff7ed26e2a62fbdfcf14..749aa186a114cd23abf8c263098f75aaa4b7ffb7 100644 (file)
--- a/t/subdir-add2-pr46.sh
+++ b/t/subdir-add2-pr46.sh
@@ -32,6 +32,10 @@ echo 'AC_CONFIG_FILES([sub/Makefile])' > confiles.m4
 
 cat > Makefile.am << 'END'
 SUBDIRS = sub
+
+# The test can fail under a parallel make, so disable.
+# No evident way to debug or reliably reproduce.
+.NOTPARALLEL:
 END
 
 mkdir sub