]> git.ipfire.org Git - thirdparty/squid.git/commitdiff
Squid crashes when ICAPS and a sslcrtvalidator used together (#328)
authorChristos Tsantilas <christos@chtsanti.net>
Tue, 25 Dec 2018 17:01:39 +0000 (17:01 +0000)
committerAmos Jeffries <yadij@users.noreply.github.com>
Wed, 26 Dec 2018 20:00:53 +0000 (09:00 +1300)
Squid hits an assertions when tries to remove an comm_close handler from
the already closed connection object.

This is a Measurement Factory project

src/adaptation/icap/Xaction.cc

index 7005b47f6fd661bbc74992457a721c35e2295d9d..6a0f8adbca2798e678d6eb5b3532985c027b0a2d 100644 (file)
@@ -744,7 +744,7 @@ Adaptation::Icap::Xaction::handleSecuredPeer(Security::EncryptorAnswer &answer)
     securer = NULL;
 
     if (closer != NULL) {
-        if (answer.conn != NULL)
+        if (Comm::IsConnOpen(answer.conn))
             comm_remove_close_handler(answer.conn->fd, closer);
         else
             closer->cancel("securing completed");