]> git.ipfire.org Git - thirdparty/FORT-validator.git/commitdiff
FIX TODO: not validating @alg
authorAlberto Leiva Popper <ydahhrk@gmail.com>
Thu, 16 May 2024 18:42:12 +0000 (12:42 -0600)
committerAlberto Leiva Popper <ydahhrk@gmail.com>
Thu, 16 May 2024 18:42:12 +0000 (12:42 -0600)
False alarm; the getter was just redundant. @alg was beind validated at
validate_certificate_public_key_algorithm().

src/object/certificate.c

index 5c83ac6623c2a230fa20495bef0f174ce950da05..51dc590f772e114f209efed3032d83012512cc38 100644 (file)
@@ -451,7 +451,6 @@ validate_public_key(X509 *cert, enum cert_type type)
 {
        X509_PUBKEY *pubkey;
        X509_ALGOR *pa;
-       ASN1_OBJECT *alg;
        int ok;
        int error;
 
@@ -460,8 +459,7 @@ validate_public_key(X509 *cert, enum cert_type type)
        if (pubkey == NULL)
                return val_crypto_err("X509_get_X509_PUBKEY() returned NULL");
 
-       /* TODO not validating @alg? */
-       ok = X509_PUBKEY_get0_param(&alg, NULL, NULL, &pa, pubkey);
+       ok = X509_PUBKEY_get0_param(NULL, NULL, NULL, &pa, pubkey);
        if (!ok)
                return val_crypto_err("X509_PUBKEY_get0_param() returned %d", ok);