cache: initialize filter when fetching implicit chains

commit e3d2a5e852ceea587bfff5878e6e5c569f15116a upstream.

ASAN reports:

  src/cache.c:734:25: runtime error: load of value 189, which is not a valid value for type '_Bool'

because filter->reset.rule remains uninitialized.

Initialize filter and replace existing construct to initialize table and
chain which leaves remaining fields uninitialized.

Fixes: dbff26bfba83 ("cache: consolidate reset command")
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>

diff --git a/src/cache.c b/src/cache.c
index d9324f74878f988f878ed7e5112f38d23b7e46af..ca00a818c20b6c90aa6625054ad54e067f706d59 100644 (file)
--- a/src/cache.c
+++ b/src/cache.c
@@ -969,13 +969,14 @@ err_ctx_list:
 static int implicit_chain_cache(struct netlink_ctx *ctx, struct table *table,
                                const char *chain_name)
 {
-       struct nft_cache_filter filter;
+       struct nft_cache_filter filter = {};
        struct chain *chain;
        int ret = 0;
 
        list_for_each_entry(chain, &table->chain_bindings, cache.list) {
                filter.list.table = table->handle.table.name;
                filter.list.chain = chain->handle.chain.name;
+
                ret = rule_init_cache(ctx, table, &filter);
        }