]> git.ipfire.org Git - thirdparty/starlette.git/commitdiff
Add type hints to `test_trusted_host.py` (#2467)
authorScirlat Danut <danut.scirlat@gmail.com>
Sun, 4 Feb 2024 15:13:48 +0000 (17:13 +0200)
committerGitHub <noreply@github.com>
Sun, 4 Feb 2024 15:13:48 +0000 (15:13 +0000)
Co-authored-by: Scirlat Danut <scirlatdanut@scirlats-mini.lan>
tests/middleware/test_trusted_host.py

index 72452cc2cf668bff3d6fe0677bb4559ba5171e76..466302210cc13dc9e0f3408751a683037e3b6b80 100644 (file)
@@ -1,12 +1,18 @@
+from typing import Callable
+
 from starlette.applications import Starlette
 from starlette.middleware import Middleware
 from starlette.middleware.trustedhost import TrustedHostMiddleware
+from starlette.requests import Request
 from starlette.responses import PlainTextResponse
 from starlette.routing import Route
+from starlette.testclient import TestClient
+
+TestClientFactory = Callable[..., TestClient]
 
 
-def test_trusted_host_middleware(test_client_factory):
-    def homepage(request):
+def test_trusted_host_middleware(test_client_factory: TestClientFactory) -> None:
+    def homepage(request: Request) -> PlainTextResponse:
         return PlainTextResponse("OK", status_code=200)
 
     app = Starlette(
@@ -31,14 +37,14 @@ def test_trusted_host_middleware(test_client_factory):
     assert response.status_code == 400
 
 
-def test_default_allowed_hosts():
+def test_default_allowed_hosts() -> None:
     app = Starlette()
     middleware = TrustedHostMiddleware(app)
     assert middleware.allowed_hosts == ["*"]
 
 
-def test_www_redirect(test_client_factory):
-    def homepage(request):
+def test_www_redirect(test_client_factory: TestClientFactory) -> None:
+    def homepage(request: Request) -> PlainTextResponse:
         return PlainTextResponse("OK", status_code=200)
 
     app = Starlette(