]> git.ipfire.org Git - thirdparty/elfutils.git/commitdiff
tests: fix build against upcoming `gcc-14` (`-Werror=calloc-transposed-args`)
authorSergei Trofimovich <slyich@gmail.com>
Thu, 21 Dec 2023 09:23:30 +0000 (09:23 +0000)
committerMark Wielaard <mark@klomp.org>
Thu, 21 Dec 2023 20:58:45 +0000 (21:58 +0100)
`gcc-14` added a new `-Wcalloc-transposed-args` warning recently. It
detected minor infelicity in `calloc()` API usage in `elfutils`:

    elfstrmerge.c: In function 'main':
    elfstrmerge.c:450:32: error:
      'calloc' sizes specified with 'sizeof' in the earlier argument and not in the later argument [-Werror=calloc-transposed-args]
      450 |   newscnbufs = calloc (sizeof (void *), newshnums);
          |                                ^~~~
    elfstrmerge.c:450:32: note: earlier argument should specify number of elements, later size of each element

Signed-off-by: Sergei Trofimovich <slyich@gmail.com>
tests/elfstrmerge.c

index 56350bb914442d8a010a284c9bdce2f129221c09..4eb58bbb583bd30407c72c28a8fa7e7d29b8b4ad 100644 (file)
@@ -447,7 +447,7 @@ main (int argc, char **argv)
     }
 
   newshnums = shdrnum - 1;
-  newscnbufs = calloc (sizeof (void *), newshnums);
+  newscnbufs = calloc (newshnums, sizeof (void *));
   if (newscnbufs == NULL)
     fail_errno ("Couldn't allocate memory for new section buffers", NULL);