]> git.ipfire.org Git - thirdparty/squid.git/commitdiff
Do not cancelStep() since an exception means that no started step(job)
authorEduard Bagdasaryan <eduard.bagdasaryan@measurement-factory.com>
Mon, 21 Dec 2020 23:02:31 +0000 (02:02 +0300)
committerEduard Bagdasaryan <eduard.bagdasaryan@measurement-factory.com>
Mon, 21 Dec 2020 23:02:31 +0000 (02:02 +0300)
See ef1a043 for details, which already fixed a similar tunnel.cc case.

src/FwdState.cc

index ca0410d28a5dcd25982e068b4322cc42a6ade6a6..d1f14a006e851099898e4bfb0acb08feac644080 100644 (file)
@@ -800,9 +800,7 @@ FwdState::advanceDestination(const char *stepDescription, const Comm::Connection
         // now wait for the step callback
     } catch (...) {
         debugs (17, 2, "exception while trying to " << stepDescription << ": " << CurrentException);
-        static const char *reason = "connection preparation exception";
-        cancelStep(reason);
-        closePendingConnection(conn, reason);
+        closePendingConnection(conn, "connection preparation exception");
         if (!err) {
             const auto error = new ErrorState(ERR_GATEWAY_FAILURE, Http::scInternalServerError, request, al);
             saveError(error);