login: ensure getutxid() does not use uninitialized variable [coverity scan]

Field ut.ut_pid is uninitialized when calling getutxline().  The safest
option is to ensure all struct data is initialized in the function.

CID: 360793
Signed-off-by: Sami Kerola <kerolasa@iki.fi>

diff --git a/login-utils/login.c b/login-utils/login.c
index 186a5ff5e459b11c844904e669a13c9414ebedd9..eaf5361712b8010abe4ab6a167ffc1ef9730f961 100644 (file)
--- a/login-utils/login.c
+++ b/login-utils/login.c
@@ -635,9 +635,9 @@ done:
  */
 static void log_utmp(struct login_context *cxt)
 {
-       struct utmpx ut;
-       struct utmpx *utp;
-       struct timeval tv;
+       struct utmpx ut = {0};
+       struct utmpx *utp = NULL;
+       struct timeval tv = {0};
 
        utmpxname(_PATH_UTMP);
        setutxent();