]> git.ipfire.org Git - thirdparty/squid.git/commitdiff
Fix parsing of certificate validator responses (#452)
authorChristos Tsantilas <christos@chtsanti.net>
Fri, 9 Aug 2019 04:18:37 +0000 (04:18 +0000)
committerAmos Jeffries <yadij@users.noreply.github.com>
Sun, 18 Aug 2019 08:25:41 +0000 (20:25 +1200)
If a certificate validator did not end its response with an end-of-line
or whitespace character, then Squid, while parsing the response,
accessed the bytes after the end of the buffer where the response is
stored.

This is a Measurement Factory project.

src/ssl/cert_validate_message.cc

index c658c80ebfc3d5d1249905a259b2c32e8355a141..4e02fd42b799b6c3834a91606fff5c05a36922fc 100644 (file)
@@ -171,7 +171,7 @@ Ssl::CertValidationMsg::parseResponse(CertValidationResponse &resp, std::string
             return false;
         }
 
-        param = value + value_len +1;
+        param = value + value_len;
     }
 
     /*Run through parsed errors to check for errors*/