]> git.ipfire.org Git - thirdparty/make.git/commitdiff
Move local headers after system headers
authorPaul Smith <psmith@gnu.org>
Mon, 3 Apr 2023 11:48:51 +0000 (07:48 -0400)
committerPaul Smith <psmith@gnu.org>
Mon, 3 Apr 2023 11:48:51 +0000 (07:48 -0400)
Avoid compiler warnings on Windows by moving local headers after
system headers.

* src/job.c: Move all headers other than makeint.h.
* src/main.c: Ditto.
* src/read.c: Ditto.

src/job.c
src/main.c
src/read.c

index 4df751321c67b811a4aad53897d27ced3335243d..34ef9b804efff8d0c71af106d20a7c1252aa19cc 100644 (file)
--- a/src/job.c
+++ b/src/job.c
@@ -19,16 +19,6 @@ this program.  If not, see <https://www.gnu.org/licenses/>.  */
 #include <assert.h>
 #include <string.h>
 
-#include "job.h"
-#include "debug.h"
-#include "filedef.h"
-#include "commands.h"
-#include "variable.h"
-#include "os.h"
-#include "dep.h"
-#include "shuffle.h"
-#include "warning.h"
-
 /* Default shell to use.  */
 #if MK_OS_W32
 # include <windows.h>
@@ -196,6 +186,16 @@ int getgid ();
 int getloadavg (double loadavg[], int nelem);
 #endif
 
+#include "job.h"
+#include "debug.h"
+#include "filedef.h"
+#include "commands.h"
+#include "variable.h"
+#include "os.h"
+#include "dep.h"
+#include "shuffle.h"
+#include "warning.h"
+
 /* Different systems have different requirements for pid_t.
    Plus we have to support gettext string translation... Argh.  */
 static const char *
index 7b8e91cfc0baef3c21f26231b1460656543c5230..6a94cfdb31c510e3565574d541e7924f9f89f520 100644 (file)
@@ -15,17 +15,6 @@ You should have received a copy of the GNU General Public License along with
 this program.  If not, see <https://www.gnu.org/licenses/>.  */
 
 #include "makeint.h"
-#include "os.h"
-#include "filedef.h"
-#include "dep.h"
-#include "variable.h"
-#include "job.h"
-#include "commands.h"
-#include "rule.h"
-#include "debug.h"
-#include "getopt.h"
-#include "shuffle.h"
-#include "warning.h"
 
 #include <assert.h>
 #if MK_OS_W32
@@ -93,6 +82,18 @@ void exit (int) NORETURN;
 double atof ();
 #endif
 
+#include "os.h"
+#include "filedef.h"
+#include "dep.h"
+#include "variable.h"
+#include "job.h"
+#include "commands.h"
+#include "rule.h"
+#include "debug.h"
+#include "getopt.h"
+#include "shuffle.h"
+#include "warning.h"
+
 static void clean_jobserver (int status);
 static void print_data_base (void);
 static void print_version (void);
index 911710814d663ff5d21abbab42778cd37445f0f2..3909fc649edce2c69a09817ab8b95f2f4e29f3b6 100644 (file)
@@ -18,6 +18,15 @@ this program.  If not, see <https://www.gnu.org/licenses/>.  */
 
 #include <assert.h>
 
+#if MK_OS_W32
+# include <windows.h>
+# include "sub_proc.h"
+#elif MK_OS_VMS
+struct passwd *getpwnam (char *name);
+#else
+# include <pwd.h>
+#endif
+
 #include "filedef.h"
 #include "dep.h"
 #include "job.h"
@@ -29,15 +38,6 @@ this program.  If not, see <https://www.gnu.org/licenses/>.  */
 #include "hash.h"
 #include "warning.h"
 
-#if MK_OS_W32
-# include <windows.h>
-# include "sub_proc.h"
-#elif MK_OS_VMS
-struct passwd *getpwnam (char *name);
-#else
-# include <pwd.h>
-#endif
-
 /* A 'struct ebuffer' controls the origin of the makefile we are currently
    eval'ing.
 */