]> git.ipfire.org Git - thirdparty/kea.git/commitdiff
[#2831] move null check closer to place of effect
authorAndrei Pavel <andrei@isc.org>
Wed, 28 Jun 2023 19:15:23 +0000 (22:15 +0300)
committerAndrei Pavel <andrei@isc.org>
Wed, 28 Jun 2023 19:45:19 +0000 (22:45 +0300)
src/lib/dns/nsec3hash.cc

index 279a2bd562e2338bb02a10be001e779e4399ca9c..c5fbd81f58c5fe4d99b673bdfc66cda08da06b3e 100644 (file)
@@ -68,11 +68,10 @@ public:
                       static_cast<unsigned int>(algorithm_));
         }
 
-        if (salt_data == NULL) {
-            isc_throw(isc::BadValue, "salt data is NULL");
-        }
-
         if (salt_length > 0) {
+            if (salt_data == NULL) {
+                isc_throw(isc::BadValue, "salt data is NULL");
+            }
             salt_data_ = static_cast<uint8_t*>(std::malloc(salt_length));
             if (salt_data_ == NULL) {
                 throw std::bad_alloc();