Apply suggestions from code review from Miod

Co-authored-by: Miod Vallat <miod.vallat@powerdns.com>
Signed-off-by: Otto Moerbeek <otto.moerbeek@open-xchange.com>

diff --git a/pdns/recursordist/mkpubsuffixcc b/pdns/recursordist/mkpubsuffixcc
index 9296d097f06786523f2e922af7732879779f0d72..02c487c015c0d933eedab445d1e7d573175205c5 100755 (executable)
--- a/pdns/recursordist/mkpubsuffixcc
+++ b/pdns/recursordist/mkpubsuffixcc
@@ -6,7 +6,9 @@ fi
 set -e
 echo "Downloading public suffix data and generating $1"
 temp=$(mktemp pubsuffixXXXXXX)
-curl -s -S https://publicsuffix.org/list/public_suffix_list.dat > $temp
+trap "rm -f $temp" 0 1 2 3 15
+set -e
+curl -o $temp -s -S https://publicsuffix.org/list/public_suffix_list.dat
 (echo "const char* g_pubsuffix[]={";
        for a in $(grep -v "//" "$temp" | grep \\. | egrep "^[.0-9a-z-]*$")
        do