]> git.ipfire.org Git - thirdparty/rrdtool-1.x.git/commitdiff
src/rrd_graph.c: fix Coverity CID#26514 Buffer not null terminated
authorMarek Schimara <Marek.Schimara@bull.net>
Thu, 16 Jun 2016 13:54:17 +0000 (15:54 +0200)
committerMarek Schimara <Marek.Schimara@bull.net>
Thu, 23 Jun 2016 14:32:33 +0000 (16:32 +0200)
        CWE-170 / https://cwe.mitre.org/data/definitions/170.html

src/rrd_graph.c

index 89024adf81db423cf38e623c9a3534bbcae79689..c0c01877035340938ea9e274cf78157cf9bf3962 100644 (file)
@@ -2090,7 +2090,8 @@ int leg_place(
         for (i = 0; i < im->gdes_c; i++) {
             char      prt_fctn; /*special printfunctions */
             if(calc_width){
-                strncpy(saved_legend, im->gdes[i].legend, sizeof saved_legend);
+                strncpy(saved_legend, im->gdes[i].legend, sizeof saved_legend - 1);
+                saved_legend[sizeof saved_legend - 1] = '\0';
             }
 
             fill_last = fill;
@@ -2256,7 +2257,8 @@ int leg_place(
             }
 
             if(calc_width){
-                strncpy(im->gdes[i].legend, saved_legend, sizeof im->gdes[0].legend);
+                strncpy(im->gdes[i].legend, saved_legend, sizeof im->gdes[0].legend - 1);
+                im->gdes[i].legend[sizeof im->gdes[0].legend - 1] = '\0';
             }
         }