]> git.ipfire.org Git - thirdparty/vala.git/commitdiff
valadoc: Drop obsolete "Driver" API
authorRico Tzschichholz <ricotz@ubuntu.com>
Mon, 1 Apr 2019 19:21:19 +0000 (21:21 +0200)
committerRico Tzschichholz <ricotz@ubuntu.com>
Mon, 1 Apr 2019 19:26:43 +0000 (21:26 +0200)
libvaladoc/Makefile.am
libvaladoc/api/driver.vala [deleted file]
valadoc/Makefile.am
valadoc/driver.vala [deleted file]
valadoc/girwriter.vala
valadoc/symbolresolver.vala
valadoc/tests/Makefile.am
valadoc/tests/drivers/generic-api-test.vala
valadoc/treebuilder.vala
valadoc/valadoc.vala

index 7456fb836cd008791f45cc433e892feb66bfcb53..73fd966c460d7820c7febea8e3501f4310f81a67 100644 (file)
@@ -88,7 +88,6 @@ libvaladoc_la_VALASOURCES = \
        api/typereference.vala \
        api/typesymbol.vala \
        api/visitor.vala \
-       api/driver.vala \
        content/block.vala \
        content/blockcontent.vala \
        content/comment.vala \
diff --git a/libvaladoc/api/driver.vala b/libvaladoc/api/driver.vala
deleted file mode 100644 (file)
index dd09ed3..0000000
+++ /dev/null
@@ -1,42 +0,0 @@
-/* driver.vala
- *
- * Copyright (C) 2011  Florian Brosch
- *
- * This library is free software; you can redistribute it and/or
- * modify it under the terms of the GNU Lesser General Public
- * License as published by the Free Software Foundation; either
- * version 2.1 of the License, or (at your option) any later version.
- *
- * This library is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
- * Lesser General Public License for more details.
- *
- * You should have received a copy of the GNU Lesser General Public
- * License along with this library; if not, write to the Free Software
- * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301  USA
- *
- * Author:
- *     Florian Brosch <flo.brosch@gmail.com>
- */
-
-
-using Valadoc.Api;
-
-/**
- * A plugin register function for drivers
- *
- * @see ModuleLoader
- */
-[CCode (has_target = false)]
-public delegate Type Valadoc.DriverRegisterFunction (ModuleLoader module_loader);
-
-
-
-public interface Valadoc.Driver : Object {
-       public abstract void write_gir (Settings settings, ErrorReporter reporter);
-
-       public abstract Api.Tree? build (Settings settings, ErrorReporter reporter);
-}
-
-
index b7fb50986c6d2cf166d4a742ca5880f1ab2e910c..89edc5578f21b1a60d2c00fa382a10ba640cdd80 100644 (file)
@@ -27,7 +27,6 @@ BUILT_SOURCES = valadoc.vala.stamp
 bin_PROGRAMS = valadoc
 
 valadoc_VALASOURCES = \
-       driver.vala \
        girwriter.vala \
        initializerbuilder.vala \
        symbolresolver.vala \
diff --git a/valadoc/driver.vala b/valadoc/driver.vala
deleted file mode 100644 (file)
index 9bd4a3e..0000000
+++ /dev/null
@@ -1,68 +0,0 @@
-/* driver.vala
- *
- * Copyright (C) 2011  Florian Brosch
- *
- * This library is free software; you can redistribute it and/or
- * modify it under the terms of the GNU Lesser General Public
- * License as published by the Free Software Foundation; either
- * version 2.1 of the License, or (at your option) any later version.
- *
- * This library is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
- * Lesser General Public License for more details.
- *
- * You should have received a copy of the GNU Lesser General Public
- * License along with this library; if not, write to the Free Software
- * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301  USA
- *
- * Author:
- *     Florian Brosch <flo.brosch@gmail.com>
- */
-
-
-using Valadoc.Api;
-
-/**
- * Creates an simpler, minimized, more abstract AST for valacs AST.
- */
-public class Valadoc.Drivers.Driver : Object, Valadoc.Driver {
-       private SymbolResolver resolver;
-       private Api.Tree? tree;
-
-       public void write_gir (Settings settings, ErrorReporter reporter) {
-               var gir_writer = new Drivers.GirWriter (resolver);
-
-               // put .gir file in current directory unless -d has been explicitly specified
-               string gir_directory = ".";
-               if (settings.gir_directory != null) {
-                       gir_directory = settings.gir_directory;
-               }
-
-               gir_writer.write_file (tree.context,
-                                                          gir_directory,
-                                                          "%s-%s.gir".printf (settings.gir_namespace, settings.gir_version),
-                                                          settings.gir_namespace,
-                                                          settings.gir_version,
-                                                          settings.pkg_name);
-       }
-
-       public Api.Tree? build (Settings settings, ErrorReporter reporter) {
-               TreeBuilder builder = new TreeBuilder ();
-               tree = builder.build (settings, reporter);
-               if (reporter.errors > 0) {
-                       return null;
-               }
-
-               resolver = new SymbolResolver (builder);
-               tree.accept (resolver);
-
-               return tree;
-       }
-}
-
-
-public Type register_plugin (Valadoc.ModuleLoader module_loader) {
-       return typeof (Valadoc.Drivers.Driver);
-}
-
index 66deb38ae24ade72b73da27e2620fe8079674056..84131eb86f9af68d20c7f13754ff78ade3e21f1f 100644 (file)
@@ -26,7 +26,7 @@ using Valadoc.Api;
 /**
  * Code visitor generating .gir file for the public interface.
  */
-public class Valadoc.Drivers.GirWriter : Vala.GIRWriter {
+public class Valadoc.GirWriter : Vala.GIRWriter {
        private GtkdocRenderer renderer;
        private SymbolResolver resolver;
 
index adf19a34a1d251f22d96215f8d384d09f719eb1c..d96b9ca72f5dc3948134d33e0b1a97d765a4eade 100644 (file)
@@ -23,7 +23,7 @@
 
 using Valadoc.Api;
 
-public class Valadoc.Drivers.SymbolResolver : Visitor {
+public class Valadoc.SymbolResolver : Visitor {
        private Vala.HashMap<Vala.Symbol, Symbol> symbol_map;
        private Valadoc.Api.Class glib_error;
        private Api.Tree root;
index b49de43cb38f0f4865d93303faddfb2e754b02bb..7f14c8a7868f93aa83a7252aee3350ce56e6c7ee 100644 (file)
@@ -43,7 +43,6 @@ check_PROGRAMS = driver
 driver_VALASOURCES = \
        drivers/driver-test.vala \
        drivers/generic-api-test.vala \
-       $(top_srcdir)/valadoc/driver.vala \
        $(top_srcdir)/valadoc/girwriter.vala \
        $(top_srcdir)/valadoc/initializerbuilder.vala \
        $(top_srcdir)/valadoc/symbolresolver.vala \
@@ -54,7 +53,6 @@ driver_SOURCES = \
        driver.vala.stamp \
        drivers/driver-test.c \
        drivers/generic-api-test.c \
-       driver.c \
        girwriter.c \
        initializerbuilder.c \
        symbolresolver.c \
index 24ef6954fc04087ac0d4e12033673e58268acd98..f8e57bb5069829531849e4bacd006c5d0da87de5 100644 (file)
@@ -2885,13 +2885,12 @@ public static void test_driver () {
        settings.path = "out";
 
 
-       var driver = new Valadoc.Drivers.Driver ();
-       assert (driver != null);
-
-
-       Api.Tree? doctree = driver.build (settings, reporter);
+       TreeBuilder builder = new TreeBuilder ();
+       Api.Tree? doctree = builder.build (settings, reporter);
        assert (reporter.errors == 0);
        assert (doctree != null);
+       SymbolResolver resolver = new SymbolResolver (builder);
+       doctree.accept (resolver);
 
 
        bool tmp = doctree.create_tree ();
index 921a72d3376521d76f3ea9433a88d1b84823af96..66638d892624e1070a536cd5359b5b5fff82e7e0 100644 (file)
@@ -26,7 +26,7 @@ using Valadoc.Api;
 /**
  * Creates an simpler, minimized, more abstract AST for valacs AST.
  */
-public class Valadoc.Drivers.TreeBuilder : Vala.CodeVisitor {
+public class Valadoc.TreeBuilder : Vala.CodeVisitor {
        private Vala.ArrayList<PackageMetaData> packages = new Vala.ArrayList<PackageMetaData> ();
        private PackageMetaData source_package;
 
index 6d5093092b4d52403becc81b946a09c8102fec9e..2bb6558f942a74bbf97fa5571c1f23d2a1bdb7d4 100644 (file)
@@ -232,8 +232,6 @@ public class ValaDoc : Object {
                settings.alternative_resource_dirs = alternative_resource_dirs;
 
 
-               var driver = new Valadoc.Drivers.Driver ();
-
                // load plugins:
                Doclet? doclet = null;
                ModuleLoader? modules = create_module_loader (reporter, out doclet);
@@ -242,11 +240,14 @@ public class ValaDoc : Object {
                }
 
                // Create tree:
-               Valadoc.Api.Tree doctree = driver.build (settings, reporter);
+               TreeBuilder builder = new TreeBuilder ();
+               Valadoc.Api.Tree doctree = builder.build (settings, reporter);
                if (reporter.errors > 0) {
                        doclet = null;
                        return quit (reporter);
                }
+               SymbolResolver resolver = new SymbolResolver (builder);
+               doctree.accept (resolver);
 
                // register child symbols:
                Valadoc.Api.ChildSymbolRegistrar registrar = new Valadoc.Api.ChildSymbolRegistrar ();
@@ -279,7 +280,13 @@ public class ValaDoc : Object {
                }
 
                if (ValaDoc.gir_name != null) {
-                       driver.write_gir (settings, reporter);
+                       var gir_writer = new GirWriter (resolver);
+                       gir_writer.write_file (doctree.context,
+                               settings.gir_directory,
+                               "%s-%s.gir".printf (settings.gir_namespace, settings.gir_version),
+                               settings.gir_namespace,
+                               settings.gir_version,
+                               settings.pkg_name);
                        if (reporter.errors > 0) {
                                return quit (reporter);
                        }